search for: 286,36

...- ttm->page_flags = page_flags; > - ttm->state = tt_unpopulated; > - ttm->swap_storage = NULL; > + ttm_tt_init_fields(ttm, bdev, size, page_flags); > > INIT_LIST_HEAD(&ttm_dma->pages_list); > if (ttm_dma_tt_alloc_page_directory(ttm_dma)) { > @@ -275,11 +286,36 @@ int ttm_dma_tt_init(struct ttm_dma_tt *ttm_dma, struct ttm_bo_device *bdev, > } > EXPORT_SYMBOL(ttm_dma_tt_init); > > +int ttm_sg_tt_init(struct ttm_dma_tt *ttm_dma, struct ttm_bo_device *bdev, > + unsigned long size, uint32_t page_flags) > +{ > + struct ttm_tt...

...; >> -    ttm->state = tt_unpopulated; >> -    ttm->swap_storage = NULL; >> +    ttm_tt_init_fields(ttm, bdev, size, page_flags); >>         INIT_LIST_HEAD(&ttm_dma->pages_list); >>       if (ttm_dma_tt_alloc_page_directory(ttm_dma)) { >> @@ -275,11 +286,36 @@ int ttm_dma_tt_init(struct ttm_dma_tt *ttm_dma, >> struct ttm_bo_device *bdev, >>   } >>   EXPORT_SYMBOL(ttm_dma_tt_init); >>   +int ttm_sg_tt_init(struct ttm_dma_tt *ttm_dma, struct >> ttm_bo_device *bdev, >> +           unsigned long size, uint32_t page...

This is why I shouldn't program before lunchtime ... v2 & v3 omitted gettext (‘f_()’) annotations around the warning and error strings. Fixed in this version. My cover letter for v2 still applies here. Rich.

...t; src_path; let packages = copy_from_virtio_win g inspect src_path dst_path - (fun _ _ -> true) in + (fun _ _ -> true) true in debug "done copying %d files" (List.length packages); let packages = List.map ((//) dst_path) packages in try @@ -286,36 +286,49 @@ and ddb_regedits inspect drv_name drv_pciid = * been copied. *) and copy_drivers g inspect driverdir = - [] <> copy_from_virtio_win g inspect "/" driverdir virtio_iso_path_matches_guest_os + [] <> copy_from_virtio_win g inspect "/" driverdir +...

This is my version of this patch which I think improves it in a number of ways. Firstly instead of having the bare boolean parameter ‘ok_if_missing’ we pass in the function we want to call along the directory missing path. This change then allows us to print a more useful error or warning message given the context of the call, and the new message is actionable too, so the user knows what has to

Sorry, there was a small mistake in v2 of the patch. The difference between v2 & v3 is below. All my other comments in the cover letter of v2 also apply here. Rich. --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -293,8 +293,7 @@ and copy_drivers g inspect driverdir = [] <> copy_from_virtio_win g inspect "/" driverdir virtio_iso_path_matches_guest_os