search for: 23c6c8e2

On 09/12/2014, 10:36 PM, Yihui Xie wrote: > I took a look at the R source and I realized that the encoding was > actually never passed to the vignette engine: > https://github.com/wch/r-source/blob/e721ef5f4/src/library/tools/R/Vignettes.R#L507 > Apparently only the file and quiet arguments are passed to the > vignette engine. Did I miss anything? I think it's actually a little

...wrote: > For the record, I saw a change had been made in R-devel: > https://github.com/wch/r-source/commit/d53b098 (Thanks, Duncan) > Meanwhile, I also made a change in knitr to assume UTF-8 unless R > passes an encoding to the vignette engine: > https://github.com/yihui/knitr/commit/23c6c8e2 Both will solve the > original problem, but apparently the former one is the ideal fix. The Windows builds of R-devel were stalled for a few days, but I've given them a kick now, so this should appear in the Windows binaries on CRAN soon. Duncan Murdoch > > Regards, > Yihui >...

For the record, I saw a change had been made in R-devel: https://github.com/wch/r-source/commit/d53b098 (Thanks, Duncan) Meanwhile, I also made a change in knitr to assume UTF-8 unless R passes an encoding to the vignette engine: https://github.com/yihui/knitr/commit/23c6c8e2 Both will solve the original problem, but apparently the former one is the ideal fix. Regards, Yihui -- Yihui Xie <xieyihui at gmail.com> Web: http://yihui.name On Wed, Dec 10, 2014 at 6:19 AM, Duncan Murdoch <murdoch.duncan at gmail.com> wrote: > On 09/12/2014, 10:36 PM, Yihui Xi...