search for: 2312c080

...that later today. For now, please review the patch :-) Gr. Matthijs -------------- next part -------------- A non-text attachment was scrubbed... Name: unroll-split.diff Type: text/x-diff Size: 31752 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080509/2312c080/attachment.diff> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080509/2312c080/attachment.sig>

Hello Matthijs, Separating mechanism from policy is a good thing for the LoopUnroll pass. Instead of moving the policy to a subclass though, I think it'd be better to move the mechanism, the unrollLoop function, out to be a standalone utility function, with the LoopInfo object passed in explicitly. FoldBlockIntoPredecessor would also be good to make into a standalone utility function, since