Displaying 3 results from an estimated 3 matches for "22ebd1c".
2019 Apr 24
1
Re: [nbdkit PATCH 4/4] filters: Check for mutex failures
...>  filters/readahead/readahead.c |  3 +--
>  filters/stats/stats.c         | 18 ++++++------------
>  filters/error/Makefile.am     |  5 ++++-
>  8 files changed, 40 insertions(+), 48 deletions(-)
I forgot to squash in:
diff --git i/filters/error/error.c w/filters/error/error.c
index 22ebd1c..add7566 100644
--- i/filters/error/error.c
+++ w/filters/error/error.c
@@ -45,6 +45,7 @@
 #include <nbdkit-filter.h>
+#include "cleanup.h"
 #include "random.h"
 #define THREAD_MODEL NBDKIT_THREAD_MODEL_PARALLEL
(Oddly enough, without that change, 'make' succee...
2019 Apr 24
7
[nbdkit PATCH 0/4] More mutex sanity checking
I do have a question about whether patch 2 is right, or whether I've
exposed a bigger problem in the truncate (and possibly other) filter,
but the rest seem fairly straightforward.
Eric Blake (4):
  server: Check for pthread lock failures
  truncate: Factor out reading real_size under mutex
  plugins: Check for mutex failures
  filters: Check for mutex failures
 filters/cache/cache.c        
2019 Apr 24
0
[nbdkit PATCH 4/4] filters: Check for mutex failures
...data, void *handle,
 {
   int r;
-  pthread_mutex_lock (&lock);
+  ACQUIRE_LOCK_FOR_CURRENT_SCOPE (&lock);
   r = blk_flush ();
   if (r == -1)
     *err = errno;
-  pthread_mutex_unlock (&lock);
   return r;
 }
diff --git a/filters/error/error.c b/filters/error/error.c
index 0f84f12..22ebd1c 100644
--- a/filters/error/error.c
+++ b/filters/error/error.c
@@ -283,9 +283,10 @@ random_error (const struct error_settings *error_settings,
    * representable in a 64 bit integer, and because we don't need all
    * this precision anyway, let's work in 32 bits.
    */
-  pthread_mutex_l...