search for: 20276d48

...C, serializing to avoid fd leaks"); + thread_model = NBDKIT_THREAD_MODEL_SERIALIZE_ALL_REQUESTS; + } +#endif + if (p->plugin.thread_model) { r = p->plugin.thread_model (); if (r == -1) diff --git a/tests/test-parallel-file.sh b/tests/test-parallel-file.sh index 8335dc99..20276d48 100755 --- a/tests/test-parallel-file.sh +++ b/tests/test-parallel-file.sh @@ -36,6 +36,9 @@ source ./functions.sh requires test -f file-data requires qemu-io --version +nbdkit --dump-plugin file | grep -q ^thread_model=parallel || + { echo "nbdkit lacks support for parallel requests&quo...

...t.com> --- tests/test-parallel-file.sh | 19 ++++++++++--------- tests/test-parallel-nbd.sh | 13 ++++++++----- tests/test-parallel-sh.sh | 19 ++++++++++--------- 3 files changed, 28 insertions(+), 23 deletions(-) diff --git a/tests/test-parallel-file.sh b/tests/test-parallel-file.sh index 20276d48..136c2db5 100755 --- a/tests/test-parallel-file.sh +++ b/tests/test-parallel-file.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash # nbdkit -# Copyright (C) 2017-2019 Red Hat Inc. +# Copyright (C) 2017-2020 Red Hat Inc. # # Redistribution and use in source and binary forms, with or without # modificatio...

On Fri, Aug 02, 2019 at 02:26:11PM -0500, Eric Blake wrote: > Allow a plugin field to declare whether a parallel plugin can tolerate > windows where fds are not CLOEXEC, or must take precautions to avoid > leaking fds if the plugin may fork. For safety reasons, the flag > defaults to off, but many in-tree plugins can set it to on (most > commonly because they don't fork after

...plugin.errno_is_preserved); + printf ("fork_safe=%d\n", !!p->plugin.fork_safe); if (p->plugin.magic_config_key) printf ("magic_config_key=%s\n", p->plugin.magic_config_key); diff --git a/tests/test-parallel-file.sh b/tests/test-parallel-file.sh index 8335dc99..20276d48 100755 --- a/tests/test-parallel-file.sh +++ b/tests/test-parallel-file.sh @@ -36,6 +36,9 @@ source ./functions.sh requires test -f file-data requires qemu-io --version +nbdkit --dump-plugin file | grep -q ^thread_model=parallel || + { echo "nbdkit lacks support for parallel requests&quo...

Either patch 1 or patch 2 in isolation is sufficient to fix the problem that Rich forwarded on from an archlinux tester (name so I can credit them?). But both patches should be applied, as well as backported to appropriate stable branches, to maximize cross-version interoperability of nbdkit vs. plugins. Patch 3 will let us detect future similar bugs much faster. I want patch 4 to ensure that

This is a major rewrite compared to my v1 series, where I've tried a lot harder to ensure that we still accommodate building on Haiku (although I have not actually yet fired up a Haiku VM to try it for myself). I also managed to make the sh plugin fully parallel, on capable platforms. See also my question on patch 10 on whether I've picked the best naming convention. Eric Blake (17):