search for: 1d8074cf

OK, after reading the docs I have some extra comments (and an updated patch). *) To support per section or per symbol attributes we would have to move this to the processing done in the end of the file. Lets not do this right now. *) We don't currently use any string attributes, so I did not implement them. *) Having an attribute emitter class is a nice way to separate the job of creating the

...accumulating the attributes locally before outputting them. Cheers, Rafael -------------- next part -------------- A non-text attachment was scrubbed... Name: attrs.patch Type: text/x-patch Size: 12333 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20101024/1d8074cf/attachment.bin>

---------- Forwarded message ---------- From: Jason Kim <jasonwkim at google.com> Date: Fri, Oct 22, 2010 at 12:59 PM Subject: Re: [llvm-commits] Fwd: Proof of concept patch for unifying the .s/ELF emission of .ARM.attributes To: Rafael Espíndola <rafael.espindola at gmail.com> On Fri, Oct 22, 2010 at 12:51 PM, Jason Kim <jasonwkim at google.com> wrote: > On Thu, Oct 21,