search for: 1c1fcff

...OLUME_CREATE_QGROUPID_BITMASK) { > + ADD_ARG (argv, i, "-i"); > + ADD_ARG (argv, i, qgroupid); > + } > + > + > ADD_ARG (argv, i, dest_buf); > ADD_ARG (argv, i, NULL); > > diff --git a/generator/actions.ml b/generator/actions.ml > index 30b839c..1c1fcff 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -10225,9 +10225,9 @@ See C<guestfs_get_e2generation>." }; > [["mkfs_btrfs"; "/dev/sda1"; ""; ""; "NOARG"; ""; "NOARG"; "NO...

...t use xstrtol to parse the output. > + reply_with_error ("%s: expected output, but got nothing", argv[0]); More than "nothing", "not a number". I'd also append the whole output here. > diff --git a/generator/actions.ml b/generator/actions.ml > index 1c1fcff..cf96039 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12005,6 +12005,15 @@ This is the same as the C<lstat(2)> system call." }; > longdesc = "\ > This is the internal call which implements C<guestfs_lstatnslist>." }; >...

...t; + ADD_ARG (argv, i, qgroupid); > > > + } > > > + > > > + > > > ADD_ARG (argv, i, dest_buf); > > > ADD_ARG (argv, i, NULL); > > > > > > diff --git a/generator/actions.ml b/generator/actions.ml > > > index 30b839c..1c1fcff 100644 > > > --- a/generator/actions.ml > > > +++ b/generator/actions.ml > > > @@ -10225,9 +10225,9 @@ See C<guestfs_get_e2generation>." }; > > > [["mkfs_btrfs"; "/dev/sda1"; ""; ""; "NOARG"; &...

...*/ + if (optargs_bitmask & GUESTFS_BTRFS_SUBVOLUME_CREATE_QGROUPID_BITMASK) { + ADD_ARG (argv, i, "-i"); + ADD_ARG (argv, i, qgroupid); + } + + ADD_ARG (argv, i, dest_buf); ADD_ARG (argv, i, NULL); diff --git a/generator/actions.ml b/generator/actions.ml index 30b839c..1c1fcff 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -10225,9 +10225,9 @@ See C<guestfs_get_e2generation>." }; [["mkfs_btrfs"; "/dev/sda1"; ""; ""; "NOARG"; ""; "NOARG"; "NOARG"; "&qu...

..." SCNi32, &r) != 1) { + reply_with_error ("%s: expected output, but got nothing", argv[0]); + return -1; + } + + return r; +} + +int do_btrfs_filesystem_sync (const char *fs) { const size_t MAX_ARGS = 64; diff --git a/generator/actions.ml b/generator/actions.ml index 1c1fcff..cf96039 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12005,6 +12005,15 @@ This is the same as the C<lstat(2)> system call." }; longdesc = "\ This is the internal call which implements C<guestfs_lstatnslist>." }; + { defaults with + name =...

...y_with_error ("%s: expected output, but got nothing", > argv[0]); > > More than "nothing", "not a number". I'd also append the whole output > here. Sounds good. > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index 1c1fcff..cf96039 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -12005,6 +12005,15 @@ This is the same as the C<lstat(2)> system > call." }; > > longdesc = "\ > > This is the internal call which implements C<guestfs_lst...

...D_ARG (argv, i, "-i"); > > + ADD_ARG (argv, i, qgroupid); > > + } > > + > > + > > ADD_ARG (argv, i, dest_buf); > > ADD_ARG (argv, i, NULL); > > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index 30b839c..1c1fcff 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -10225,9 +10225,9 @@ See C<guestfs_get_e2generation>." }; > > [["mkfs_btrfs"; "/dev/sda1"; ""; ""; "NOARG"; ""; "N...

Hi, This is the part1 of improving btrfs support. This series adds missing parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. Other parts will follow. Regards, Hu Hu Tao (6): btrfs: correct words about subvolume and snapshot btrfs: add optional parameter `ro' to btrfs_subvolume_snapshot btrfs: