Displaying 3 results from an estimated 3 matches for "1be5941c1".
2017 Oct 04
1
Re: [PATCH 2/9] ocaml: Replace pattern matching { field = field } with { field }.
...far, I guess we do not
have many users left on old OCaml versions (old distros, actually).
OOC, did you use a script to detect all these occurrences, or did you
just manually scan through the code?
> diff --git a/sysprep/sysprep_operation.ml b/sysprep/sysprep_operation.ml
> index 5c5640c67..1be5941c1 100644
> --- a/sysprep/sysprep_operation.ml
> +++ b/sysprep/sysprep_operation.ml
> @@ -172,7 +172,7 @@ let extra_args () =
> assert !baked;
>
> List.flatten (
> - List.map (fun { extra_args = extra_args } ->
> + List.map (fun { extra_args } ->
>...
2017 Oct 04
11
[PATCH 0/9] build: Require OCaml >= 4.02.
Per my previous email:
https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html
I'd like to talk about requiring a more modern version of the OCaml
compiler.
These commits show some of the code changes which would be possible
with OCaml >= 3.12 [which it turns out we already require by accident]
and also with OCaml >= 4.02. The latter is my favoured option.
Rich.
2017 Oct 04
0
[PATCH 2/9] ocaml: Replace pattern matching { field = field } with { field }.
...{ URI.path; protocol; server; username; password } = uri in
let discard = if readonly then None else Some "besteffort" in
g#add_drive
~readonly ?discard
diff --git a/sysprep/sysprep_operation.ml b/sysprep/sysprep_operation.ml
index 5c5640c67..1be5941c1 100644
--- a/sysprep/sysprep_operation.ml
+++ b/sysprep/sysprep_operation.ml
@@ -172,7 +172,7 @@ let extra_args () =
assert !baked;
List.flatten (
- List.map (fun { extra_args = extra_args } ->
+ List.map (fun { extra_args } ->
List.map (fun { extra_argspec = argspec } -&...