search for: 19ce555

...ze a bounce buffer when we already have aligned data. Signed-off-by: Eric Blake <eblake@redhat.com> --- filters/cache/cache.c | 60 ++++++++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 21 deletions(-) diff --git a/filters/cache/cache.c b/filters/cache/cache.c index 19ce555..98786b5 100644 --- a/filters/cache/cache.c +++ b/filters/cache/cache.c @@ -1,5 +1,5 @@ /* nbdkit - * Copyright (C) 2018 Red Hat Inc. + * Copyright (C) 2018-2019 Red Hat Inc. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that th...

...assed to next, create a per-connection handle, or both. Signed-off-by: Eric Blake <eblake@redhat.com> --- filters/cache/cache.c | 10 ---------- filters/error/error.c | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/filters/cache/cache.c b/filters/cache/cache.c index b3fef42..19ce555 100644 --- a/filters/cache/cache.c +++ b/filters/cache/cache.c @@ -186,15 +186,6 @@ cache_config_complete (nbdkit_next_config_complete *next, void *nxdata) return next (nxdata); } -static void * -cache_open (nbdkit_next_open *next, void *nxdata, int readonly) -{ - if (next (nxdata, readonly)...

...aligned data. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > filters/cache/cache.c | 60 ++++++++++++++++++++++++++++--------------- > 1 file changed, 39 insertions(+), 21 deletions(-) > > diff --git a/filters/cache/cache.c b/filters/cache/cache.c > index 19ce555..98786b5 100644 > --- a/filters/cache/cache.c > +++ b/filters/cache/cache.c > @@ -1,5 +1,5 @@ > /* nbdkit > - * Copyright (C) 2018 Red Hat Inc. > + * Copyright (C) 2018-2019 Red Hat Inc. > * > * Redistribution and use in source and binary forms, with or without > *...

...ic Blake <eblake@redhat.com> --- filters/cache/cache.c | 173 +++++++++++++++++++++++++++++----------- filters/cow/cow.c | 180 +++++++++++++++++++++++++++++++----------- 2 files changed, 263 insertions(+), 90 deletions(-) diff --git a/filters/cache/cache.c b/filters/cache/cache.c index 19ce555..360458f 100644 --- a/filters/cache/cache.c +++ b/filters/cache/cache.c @@ -1,5 +1,5 @@ /* nbdkit - * Copyright (C) 2018 Red Hat Inc. + * Copyright (C) 2018-2019 Red Hat Inc. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that th...

While working on adding assertions to pthread_mutex_lock calls, I noticed that the truncate filter's use of mutex didn't really protect us, and isn't really necessary. Cleaning that up also spotted a couple of other potential cleanups. Eric Blake (4): filters: Drop useless .open callbacks truncate: Fix corruption when plugin changes per-connection size truncate: Test for safe

Based on Rich's review of my v1 that touched only cache.c, I have now tried to bring all three filters with alignment rounding in line with one another. There is definitely room for future improvements once we teach nbdkit to let filters and plugins advertise block sizes, but I'm hoping to get NBD_CMD_CACHE implemented first. Eric Blake (2): blocksize: Process requests in linear order