search for: 1989390

On 2018/11/21 ??6:03, Tiwei Bie wrote: > Add types and macros for packed ring. > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > include/uapi/linux/virtio_config.h | 3 +++ > include/uapi/linux/virtio_ring.h | 52 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 55 insertions(+) > > diff --git a/include/uapi/linux/virtio_config.h

On 2018/11/21 ??6:03, Tiwei Bie wrote: > Add types and macros for packed ring. > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > include/uapi/linux/virtio_config.h | 3 +++ > include/uapi/linux/virtio_ring.h | 52 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 55 insertions(+) > > diff --git a/include/uapi/linux/virtio_config.h

...oks inconsistent to previous flags, any reason for using shifts? > > > > > > > > Yeah, it was suggested to use shifts, as _F_ should be a bit > > > > number, not a shifted value: > > > > > > > > https://patchwork.ozlabs.org/patch/942296/#1989390 > > > > > > But let's add a _SPLIT_ variant that uses shifts consistently. > > > > Maybe we could avoid adding SPLIT and PACKED, but define as follow: > > > > #define VRING_DESC_F_INDIRECT_SHIFT 2 > > #define VRING_DESC_F_INDIRECT (1ull <&lt...

...oks inconsistent to previous flags, any reason for using shifts? > > > > > > > > Yeah, it was suggested to use shifts, as _F_ should be a bit > > > > number, not a shifted value: > > > > > > > > https://patchwork.ozlabs.org/patch/942296/#1989390 > > > > > > But let's add a _SPLIT_ variant that uses shifts consistently. > > > > Maybe we could avoid adding SPLIT and PACKED, but define as follow: > > > > #define VRING_DESC_F_INDIRECT_SHIFT 2 > > #define VRING_DESC_F_INDIRECT (1ull <&lt...

...using shifts? > > > > > > > > > > > > Yeah, it was suggested to use shifts, as _F_ should be a bit > > > > > > number, not a shifted value: > > > > > > > > > > > > https://patchwork.ozlabs.org/patch/942296/#1989390 > > > > > > > > > > But let's add a _SPLIT_ variant that uses shifts consistently. > > > > > > > > Maybe we could avoid adding SPLIT and PACKED, but define as follow: > > > > > > > > #define VRING_DESC_F_INDIRECT_S...

...using shifts? > > > > > > > > > > > > Yeah, it was suggested to use shifts, as _F_ should be a bit > > > > > > number, not a shifted value: > > > > > > > > > > > > https://patchwork.ozlabs.org/patch/942296/#1989390 > > > > > > > > > > But let's add a _SPLIT_ variant that uses shifts consistently. > > > > > > > > Maybe we could avoid adding SPLIT and PACKED, but define as follow: > > > > > > > > #define VRING_DESC_F_INDIRECT_S...

...> > + * Notice: they are defined as shifts instead of shifted values. > > > This looks inconsistent to previous flags, any reason for using shifts? Yeah, it was suggested to use shifts, as _F_ should be a bit number, not a shifted value: https://patchwork.ozlabs.org/patch/942296/#1989390 > > > > + */ > > +#define VRING_PACKED_DESC_F_AVAIL 7 > > +#define VRING_PACKED_DESC_F_USED 15 > > + > > /* The Host uses this in used->flags to advise the Guest: don't kick me when > > * you add a buffer. It's unreliable, so it's si...

...t; > > > This looks inconsistent to previous flags, any reason for using shifts? > > > > > > Yeah, it was suggested to use shifts, as _F_ should be a bit > > > number, not a shifted value: > > > > > > https://patchwork.ozlabs.org/patch/942296/#1989390 > > > > But let's add a _SPLIT_ variant that uses shifts consistently. > > Maybe we could avoid adding SPLIT and PACKED, but define as follow: > > #define VRING_DESC_F_INDIRECT_SHIFT 2 > #define VRING_DESC_F_INDIRECT (1ull << VRING_DESC_F_INDIRECT_SHIFT) &gt...

...ous flags, any reason for using shifts? > > > > > > > > > > Yeah, it was suggested to use shifts, as _F_ should be a bit > > > > > number, not a shifted value: > > > > > > > > > > https://patchwork.ozlabs.org/patch/942296/#1989390 > > > > > > > > But let's add a _SPLIT_ variant that uses shifts consistently. > > > > > > Maybe we could avoid adding SPLIT and PACKED, but define as follow: > > > > > > #define VRING_DESC_F_INDIRECT_SHIFT 2 > > > #define...

...> > > > > > > > > > > > Yeah, it was suggested to use shifts, as _F_ should be a bit > > > > > > > number, not a shifted value: > > > > > > > > > > > > > > https://patchwork.ozlabs.org/patch/942296/#1989390 > > > > > > > > > > > > But let's add a _SPLIT_ variant that uses shifts consistently. > > > > > > > > > > Maybe we could avoid adding SPLIT and PACKED, but define as follow: > > > > > > > > > > #...