search for: 1588451

https://bugzilla.redhat.com/show_bug.cgi?id=1588451 v2 was here: https://www.redhat.com/archives/libguestfs/2018-June/msg00067.html This is a greatly simplified version, which just changes the libvirt backend to make the path absolute. None of the tests need to be adjusted. Rich.

...s.h> #include <fcntl.h> #include <grp.h> #include <errno.h> @@ -1698,8 +1699,20 @@ construct_libvirt_xml_disk_source_hosts (guestfs_h *g, } case drive_transport_unix: { + /* libvirt requires sockets to be specified as an absolute path + * (RHBZ#1588451). + */ + const char *socket = src->servers[i].u.socket; + CLEANUP_FREE char *abs_socket = realpath (socket, NULL); + + if (abs_socket == NULL) { + perrorf (g, _("realpath: could not convert ‘%s’ to absolute path"), + socket); +...

...646,18 @@ parse_one_server (guestfs_h *g, const char *server, struct drive_server *ret) return -1; } ret->transport = drive_transport_unix; - ret->u.socket = safe_strdup (g, server+5); + + /* libvirt requires sockets to be specified as an absolute path + * (see RHBZ#1588451), and it's probably a good idea anyway to + * check the socket exists and convert it to an absolute path. + */ + ret->u.socket = realpath (server+5, NULL); + if (ret->u.socket == NULL) { + perrorf (g, _("realpath: could not convert ‘%s’ to an absolute path"),...

One interesting omission is that we don't allow sockets in the abstract namespace. The API won't let you pass these sockets because they contain a '\0' character in the middle of the string. Therefore this patch doesn't need to deal with those. However we should in future allow that, probably using the '@' character to stand in for the NUL byte, as is used in a few

...rpm -ql kernel-2.6.18-128.el5 command https://bugzilla.redhat.com/1591789 p2v: error: XML error: CPU vendor specified without CPU model https://bugzilla.redhat.com/1590220 Hide rhv-upload option in virt-p2v client https://bugzilla.redhat.com/1588451 Don't use relative socket paths for NBD https://bugzilla.redhat.com/1588088 RFE: Support for -o rhv-upload via Unix domain socket https://bugzilla.redhat.com/1586198 ovirt-imageio-daemon times out during migration https://bugzilla.redhat....