search for: 11d9cc9

...to avoid two branches on data path. So I'm not sure anymore: with my patch it's pretty clear how the code works. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> but I don't think we need to apply this. diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 11d9cc9..1cc2e43 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -296,6 +296,14 @@ static struct sk_buff *page_to_skb(struct receive_queue *rq, return skb; } +static void *rq_get_buf(struct receive_queue *rq, unsigned int *len) +{ + void *buf = virtqueue_get_buf(rq->vq, len)...

...to avoid two branches on data path. So I'm not sure anymore: with my patch it's pretty clear how the code works. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> but I don't think we need to apply this. diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 11d9cc9..1cc2e43 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -296,6 +296,14 @@ static struct sk_buff *page_to_skb(struct receive_queue *rq, return skb; } +static void *rq_get_buf(struct receive_queue *rq, unsigned int *len) +{ + void *buf = virtqueue_get_buf(rq->vq, len)...

On Wed, Nov 20, 2013 at 05:07:26PM +0800, Jason Wang wrote: > We need decrease the rq->num after we can get a buf through > virtqueue_get_buf() even if we could not allocate frag skb. Otherwise, the > refill routine won't be triggered under heavy memory stress since the driver may > still think there's enough room. > > This bug was introduced by commit

On Wed, Nov 20, 2013 at 05:07:26PM +0800, Jason Wang wrote: > We need decrease the rq->num after we can get a buf through > virtqueue_get_buf() even if we could not allocate frag skb. Otherwise, the > refill routine won't be triggered under heavy memory stress since the driver may > still think there's enough room. > > This bug was introduced by commit