search for: 1092583

Hi, one of the bugs we have (#1092583) is about the lack of query string for http/https URLs: there were patches about that (not merged yet), whose solution was to add a new optional argument "querystring". Another bug that I'm looking at (#1118305) is about setting initiator IQNs for iSCSI drives; a good solution IMHO w...

I have written a patch (please see attached) which fixes both of these bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1092583 https://bugzilla.redhat.com/show_bug.cgi?id=1232477 By default, when saving a URI using xmlSaveUri it escapes everything in the URI. QEMU doesn't want anything escaped, so now I unescape everything after the URI is generated. Unfortunately there's no flag to change the default behavior....

On Thursday 03 December 2015 11:52:14 Richard W.M. Jones wrote: > On Wed, Dec 02, 2015 at 02:10:52PM +0100, Pino Toscano wrote: > > Hi, > > > > one of the bugs we have (#1092583) is about the lack of query string > > for http/https URLs: there were patches about that (not merged yet), > > whose solution was to add a new optional argument "querystring". > > > > Another bug that I'm looking at (#1118305) is about setting initiator >...

Parse the query string from URLs, and pass it as new add_drive optarg; use it when building the file= URL for qemu. Accept query string only for http and https protocols, for now. --- Possibly it looks like an ad-hoc solution for http(s), although I'm not sure how it could possibly be generalized somehow (maybe "extra params" which would be the query string for http(s)?).

I'm trying to read the contents of a remote vhd and running into some problems. I suspect the issue has to do with the inclusion of a SAS key in the url. Does anyone have any experience with this, or recommendations on where to begin looking to make a fix? Here's the verbose (debug) log and command I'm trying to run. https://gist.github.com/gabrielhartmann/6114578065eae011a2b3 --

On Thu, Jun 25, 2015 at 06:44:50PM +0000, Gabriel Hartmann wrote: > I have written a patch (please see attached) which fixes both of these bugs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > By default, when saving a URI using xmlSaveUri it escapes everything in the > URI. QEMU doesn't want anything escaped, so now I unescape everything > after the URI is generated. Unfortunately there's no flag to chan...

On Wed, Dec 02, 2015 at 02:10:52PM +0100, Pino Toscano wrote: > Hi, > > one of the bugs we have (#1092583) is about the lack of query string > for http/https URLs: there were patches about that (not merged yet), > whose solution was to add a new optional argument "querystring". > > Another bug that I'm looking at (#1118305) is about setting initiator > IQNs for iSCSI drive...

Hi, sorry for the late reply, this email fall behind in my queue. On Friday, 15 March 2019 19:00:18 CEST Chintan Patel wrote: > We have some change for libguestfs to include query string in URL. This was reported years ago: https://bugzilla.redhat.com/show_bug.cgi?id=1092583 While adding a querystring optional argument looks like an easy solution, in reality it opens a can of worms, as it would be a generic passthrough for options, and not really easy to handle by libguestfs. For few more details, see also the following email with a possible way to implement this that...

Hi, In data giovedì 25 giugno 2015 18:44:50, Gabriel Hartmann ha scritto: > I have written a patch (please see attached) which fixes both of these bugs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > By default, when saving a URI using xmlSaveUri it escapes everything in the > URI. QEMU doesn't want anything escaped, so now I unescape everything > after the URI is generated. Unfortunately there's no flag to chan...

...29, 2015 at 4:03 AM Richard W.M. Jones <rjones@redhat.com> wrote: > On Thu, Jun 25, 2015 at 06:44:50PM +0000, Gabriel Hartmann wrote: > > I have written a patch (please see attached) which fixes both of these > bugs: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > > > By default, when saving a URI using xmlSaveUri it escapes everything in > the > > URI. QEMU doesn't want anything escaped, so now I unescape everything > > after the URI is generated. Unfortunatel...

...elements, properly passing it as "secret" parameter for add-drive, and properly readd it when building URLs in the direct backend. Furthmore, to keep curl- and ssh-based qemu drivers working with authenticated resources, make sure they can accept secrets. Reported in comment #1 of RHBZ#1092583. --- customize/customize_main.ml | 5 +++-- fish/options.c | 6 ++++++ fish/options.h | 1 + fish/uri.c | 26 ++++++++++++++++++++++---- fish/uri.h | 1 + mllib/uRI.ml | 1 + mllib/uRI.mli | 1 + mllib/u...

Hi All, Here's the latest patch. I think this should address the problem. The query string is now only appended to the end of a URI in the HTTP and HTTPS cases. The add-uri test now passes, and 'make check' still passes. -- Gabriel