search for: 1048064

...ot;full.pid $sock full.out" @@ -47,13 +47,27 @@ cleanup_fn rm -f $files start_nbdkit -P full.pid -U $sock full 1M # All reads should succeed. -qemu-io -f raw "nbd+unix://?socket=$sock" \ - -c 'r -v 0 512' \ - -c 'r -v 512 512' \ - -c 'r -v 1048064 512' +nbdsh --connect "nbd+unix://?socket=$sock" \ + -c 'h.pread (512, 0)' \ + -c 'h.pread (512, 512)' \ + -c 'h.pread (512, 1048064)' # All writes should fail with the ENOSPC error. -! LANG=C qemu-io -f raw "nbd+unix://?socket=$sock&quot...

Very much a work in progress as there are still many tests using qemu-io which are candidates for conversion. You'll notice at the end of test-full.sh that the new test has some duplicated code which looks as if it ought to be refactored into a Python function. When I tried to do that, I got loads of strange Python problems which may indicate bugs in nbdsh itself or problems with my

...uot;ENOSPC" +def test (offset): + try: + h.pwrite (bytearray (512), offset) + # This should not happen. + exit (1) + except nbd.Error as ex: + # Check the errno is expected. + assert ex.errno == "ENOSPC" -try: - h.pwrite (bytearray (512), 1048064) - # This should not happen. - exit (1) -except nbd.Error as ex: - # Check the errno is expected. - assert ex.errno == "ENOSPC" +test (0) +test (1048064) ' -- 2.23.0 --185D1s7FREAUfc0L Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename...

...ta":false,"zero":true} +EOF +do_test "" 65536 1M "$pid3" + +# Completely allocated disk. +cat > $expected <<'EOF' +{"start":0,"length":512,"data":true,"zero":false} +{"start":512,"length":1048064,"data":false,"zero":true} +EOF +do_test "1" 512 1M "$pid4" + +# Zero-length plugin. Unlike nbdkit-zero-plugin, the data plugin +# advertises extents and so will behave differently. +cat > $expected <<'EOF' +{"start":0,"length&...

Updated based on other changes that have happened in the meantime: - rely more on cleanup.h (throughout) - split structured read for easier review (patch 2 and 3 were combined in v1) - rely on nbdkit not leaking a server's partial answer (patch 3) - add tests (patch 5) - other bug fixes I found while testing it - drop EOVERFLOW patch for now; it will be separate once upstream NBD protocol

Hi Rich, This is v3 series to add support for resizing MBR logical partitions. changes to v3: 1. merge patch 1 and patch 3 in v3 2. let mbr_part_type return 'primary' for GPT partitions 3. add test for resizing logical partitions 4. fix extending the extended partition (yet). see patch 7. changes to v2: 1. remove p_part_num 2. remove filter_parts 3. name the function

This has already been pushed upstream. I am simply posting these here so we have a reference in the mailing list in case we find bugs later (as I'm sure we will - it's a complex patch series). Great thanks to Eric Blake for tireless review on this one. It also seems to have identified a few minor bugs in qemu along the way. Rich.