search for: 101db3f

...e of each device - try to find a device that is sharing one MSI for all vqs, try to allocate one MSI for each vq BTW, I saw we still notify all vqs even VIRTIO_PCI_ISR_CONFIG bit of isr is set, is it necessary? diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 101db3f..176aabc 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -259,9 +259,9 @@ static irqreturn_t vp_interrupt(int irq, void *opaque) /* Configuration change? Tell driver if it wants to know. */ if (isr & VIRTIO_PCI_ISR_CONFIG) - vp_conf...

...e of each device - try to find a device that is sharing one MSI for all vqs, try to allocate one MSI for each vq BTW, I saw we still notify all vqs even VIRTIO_PCI_ISR_CONFIG bit of isr is set, is it necessary? diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 101db3f..176aabc 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -259,9 +259,9 @@ static irqreturn_t vp_interrupt(int irq, void *opaque) /* Configuration change? Tell driver if it wants to know. */ if (isr & VIRTIO_PCI_ISR_CONFIG) - vp_conf...

Hi Rusty et al, Based on recently accepted to the mainline pci_enable_msix_exact() function, I am sending a updated version of the patch. Please, let me know if it does not work for you and you need and incremental update from the previous version. Thanks! -- Regards, Alexander Gordeev agordeev at redhat.com

Hi Rusty et al, Based on recently accepted to the mainline pci_enable_msix_exact() function, I am sending a updated version of the patch. Please, let me know if it does not work for you and you need and incremental update from the previous version. Thanks! -- Regards, Alexander Gordeev agordeev at redhat.com

...sell <rusty at rustcorp.com.au> Cc: Michael Tsirkin <mst at redhat.com> Signed-off-by: Anthony Liguori <aliguori at amazon.com> --- drivers/virtio/virtio_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 101db3f..9cbac33 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -93,6 +93,8 @@ struct virtio_pci_vq_info /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */ static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) = { { PCI_DEVICE(0x1af4, PCI_ANY_ID) }, + /*...

...sell <rusty at rustcorp.com.au> Cc: Michael Tsirkin <mst at redhat.com> Signed-off-by: Anthony Liguori <aliguori at amazon.com> --- drivers/virtio/virtio_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 101db3f..9cbac33 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -93,6 +93,8 @@ struct virtio_pci_vq_info /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */ static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) = { { PCI_DEVICE(0x1af4, PCI_ANY_ID) }, + /*...

...irtio-dev at lists.oasis-open.org Cc: virtualization at lists.linux-foundation.org Cc: linux-pci at vger.kernel.org --- drivers/virtio/virtio_pci.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index a416f9b..101db3f 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -333,10 +333,8 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, for (i = 0; i < nvectors; ++i) vp_dev->msix_entries[i].entry = i; - /* pci_enable_msix returns positive if we can...

...c: virtualization at lists.linux-foundation.org > Cc: linux-pci at vger.kernel.org > --- > drivers/virtio/virtio_pci.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c > index a416f9b..101db3f 100644 > --- a/drivers/virtio/virtio_pci.c > +++ b/drivers/virtio/virtio_pci.c > @@ -333,10 +333,8 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, > for (i = 0; i < nvectors; ++i) > vp_dev->msix_entries[i].entry = i; > > - /* pci_ena...

...ue was reported by checkpatch. Signed-off-by: Benoit Taine <benoit.taine at lip6.fr> --- Tested by compilation without errors. drivers/virtio/virtio_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 101db3f..3d1463c 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -91,7 +91,7 @@ struct virtio_pci_vq_info }; /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */ -static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) = { +static const struct pci_device_id v...

...c: virtualization at lists.linux-foundation.org > Cc: linux-pci at vger.kernel.org > --- > drivers/virtio/virtio_pci.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c > index a416f9b..101db3f 100644 > --- a/drivers/virtio/virtio_pci.c > +++ b/drivers/virtio/virtio_pci.c > @@ -333,10 +333,8 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, > for (i = 0; i < nvectors; ++i) > vp_dev->msix_entries[i].entry = i; > > - /* pci_ena...

...see the response/confirmation of the above, and/or the commit log replaced before this patch is applied. Thanks! > --- > drivers/virtio/virtio_pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c > index 101db3f..9cbac33 100644 > --- a/drivers/virtio/virtio_pci.c > +++ b/drivers/virtio/virtio_pci.c > @@ -93,6 +93,8 @@ struct virtio_pci_vq_info > /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */ > static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) = { > { PCI_DEVI...

...ve, and/or the > commit log replaced before this patch is applied. > > Thanks! > >> --- >> drivers/virtio/virtio_pci.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c >> index 101db3f..9cbac33 100644 >> --- a/drivers/virtio/virtio_pci.c >> +++ b/drivers/virtio/virtio_pci.c >> @@ -93,6 +93,8 @@ struct virtio_pci_vq_info >> /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */ >> static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) =...

...ve, and/or the > commit log replaced before this patch is applied. > > Thanks! > >> --- >> drivers/virtio/virtio_pci.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c >> index 101db3f..9cbac33 100644 >> --- a/drivers/virtio/virtio_pci.c >> +++ b/drivers/virtio/virtio_pci.c >> @@ -93,6 +93,8 @@ struct virtio_pci_vq_info >> /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */ >> static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) =...

...e this patch is applied. > > > > Thanks! > > > >> --- > >> drivers/virtio/virtio_pci.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c > >> index 101db3f..9cbac33 100644 > >> --- a/drivers/virtio/virtio_pci.c > >> +++ b/drivers/virtio/virtio_pci.c > >> @@ -93,6 +93,8 @@ struct virtio_pci_vq_info > >> /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */ > >> static DEFINE_PCI_DEVICE_TAB...

We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const

We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const