search for: 0xh

I've got comments on the code change. The test cases look ok, but I haven't fully checked the math on the half-values. I checked with reference to trunk top-of-tree at revision 156617. I have not compiled the code. lib/AsmParser/LLLexer.cpp Adds support to parse format: 0xH<hexdigits> Tha 0xH format should be described in LangRef.html alongside 0xK<hex> and 0xM<hex> The code looks good though. lib/VMCore/AsmWriter.cpp The change updates Printing support for half data type, so it uses the new special 0xH<hex> form. Declarat...

Hi David, Many thanks for the comments! > Tha 0xH format should be described in LangRef.html alongside > 0xK<hex> and 0xM<hex> Done. > Declaration of "int shiftcount" should be moved to smallest nesting > possible, right after "if ( const ConstantFP ..." at line 710 > > (The code makes a lo...

...s at cs.uiuc.edu] > On Behalf Of Anton Lokhmotov > Sent: Thursday, May 17, 2012 4:51 AM > To: 'David Neto' > Cc: llvmdev at cs.uiuc.edu > Subject: Re: [LLVMdev] [PATCH] OpenCL half support > > Hi David, > > Many thanks for the comments! > > > Tha 0xH format should be described in LangRef.html alongside > > 0xK<hex> and 0xM<hex> > Done. > > > Declaration of "int shiftcount" should be moved to smallest nesting > > possible, right after "if ( const ConstantFP ..." at line 710 > >...

...otov > > Sent: Thursday, May 17, 2012 4:51 AM > > To: 'David Neto' > > Cc: llvmdev at cs.uiuc.edu > > Subject: Re: [LLVMdev] [PATCH] OpenCL half support > > > > Hi David, > > > > Many thanks for the comments! > > > > > Tha 0xH format should be described in LangRef.html alongside > > > 0xK<hex> and 0xM<hex> > > Done. > > > > > Declaration of "int shiftcount" should be moved to smallest > nesting > > > possible, right after "if ( const ConstantFP .....