search for: 0x20340

https://bugs.freedesktop.org/show_bug.cgi?id=107016 Bug ID: 107016 Summary: Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02) Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

...ld spend some time hooking up my osciloscope to the VR to check if it is a bringup issue but it would not help Nouveau much as we need to reproduce the behaviour of RM anyway since this is the only validated configuration. Thanks in advance, Martin PS: The registers for this PWM controller are 0x20340 and 0x20344.

...ubdev/volt/gk104.c > @@ -40,10 +40,15 @@ gk104_volt_get(struct nvkm_volt *base) > { > struct nvbios_volt *bios = &gk104_volt(base)->bios; > struct nvkm_device *device = base->subdev.device; > - u32 div, duty; > + int div, duty; > > div = nvkm_rd32(device, 0x20340); > + if (div < 0) > + return div; > + > duty = nvkm_rd32(device, 0x20344); > + if (duty < 0) > + return duty; > > return bios->base + bios->pwm_range * duty / div; > } > -- > 2.14.1 > > _______________________________________________ &g...

...volt_set(struct nvkm_volt *base, u32 uv) /* the blob uses this crystal frequency, let's use it too. */ div = 27648000 / bios->pwm_freq; - duty = (uv - bios->base) * div / bios->pwm_range; + duty = DIV_ROUND_UP((uv - bios->base) * div, bios->pwm_range); nvkm_wr32(device, 0x20340, div); nvkm_wr32(device, 0x20344, 0x80000000 | duty); -- 2.8.1

...ev/volt/gk104.c +++ b/drm/nouveau/nvkm/subdev/volt/gk104.c @@ -39,10 +39,15 @@ gk104_volt_get(struct nvkm_volt *base) { struct nvbios_volt *bios = &gk104_volt(base)->bios; struct nvkm_device *device = base->subdev.device; - u32 div, duty; + int div, duty; div = nvkm_rd32(device, 0x20340); + if (div < 0) + return div; + duty = nvkm_rd32(device, 0x20344); + if (duty < 0) + return duty; return bios->base + bios->pwm_range * duty / div; } -- 2.9.2

...ev/volt/gk104.c +++ b/drm/nouveau/nvkm/subdev/volt/gk104.c @@ -40,10 +40,15 @@ gk104_volt_get(struct nvkm_volt *base) { struct nvbios_volt *bios = &gk104_volt(base)->bios; struct nvkm_device *device = base->subdev.device; - u32 div, duty; + int div, duty; div = nvkm_rd32(device, 0x20340); + if (div < 0) + return div; + duty = nvkm_rd32(device, 0x20344); + if (duty < 0) + return duty; return bios->base + bios->pwm_range * duty / div; } -- 2.14.1

We should simply return errors while the GPU is turned off, because the sensors aren't accessable and setting any kind of value doesn't make any sense. Fixes sensors values reported by "sensors" Before: nouveau-pci-0100 Adapter: PCI adapter GPU core: +0.60 V (min = +0.60 V, max = +1.20 V) temp1: -0.0°C (high = +95.0°C, hyst = +3.0°C) (crit

Just wanted to post updated versions of my last series/patches. Reviews welcomed. It would be also nice if we agree on features I should focus upstreaming, so that this work can be better splitted or reordered. Sadly most of my patches depend on the rather big clk subdev rework and I think those patches shows best, why I think this rework is actually needed and makes things much easier to add