search for: 09d1dc7

On Tue, 20 Feb 2018 21:14:10 +0100, Jiri Pirko wrote: > Yeah, I can see it now :( I guess that the ship has sailed and we are > stuck with this ugly thing forever... > > Could you at least make some common code that is shared in between > netvsc and virtio_net so this is handled in exacly the same way in both? IMHO netvsc is a vendor specific driver which made a mistake on what

On Tue, 20 Feb 2018 21:14:10 +0100, Jiri Pirko wrote: > Yeah, I can see it now :( I guess that the ship has sailed and we are > stuck with this ugly thing forever... > > Could you at least make some common code that is shared in between > netvsc and virtio_net so this is handled in exacly the same way in both? IMHO netvsc is a vendor specific driver which made a mistake on what

...fo, th) { + if (team_is_ifinfo_hwaddr_changed(ifinfo) || + team_is_ifinfo_hwaddr_len_changed(ifinfo)) { + err = teamd_event_unlinked_ifinfo_hwaddr_changed(ctx, ifinfo); + if (err) + return err; + } + } return 0; } diff --git a/teamd/teamd_per_port.c b/teamd/teamd_per_port.c index 09d1dc7..21e1bda 100644 --- a/teamd/teamd_per_port.c +++ b/teamd/teamd_per_port.c @@ -331,6 +331,11 @@ next_one: return tdport; } +int teamd_port_add(struct teamd_context *ctx, uint32_t ifindex) +{ + return team_port_add(ctx->th, ifindex); +} + int teamd_port_add_ifname(struct teamd_context *ctx,...

...tered? I haven't worked on teamd so I am not familiar with how it handles new interfaces. Also how does this handle existing interfaces that were registered before you started this? > return 0; > } > > diff --git a/teamd/teamd_per_port.c b/teamd/teamd_per_port.c > index 09d1dc7..21e1bda 100644 > --- a/teamd/teamd_per_port.c > +++ b/teamd/teamd_per_port.c > @@ -331,6 +331,11 @@ next_one: > return tdport; > } > > +int teamd_port_add(struct teamd_context *ctx, uint32_t ifindex) > +{ > + return team_port_add(ctx->th, ifindex); >...

...tered? I haven't worked on teamd so I am not familiar with how it handles new interfaces. Also how does this handle existing interfaces that were registered before you started this? > return 0; > } > > diff --git a/teamd/teamd_per_port.c b/teamd/teamd_per_port.c > index 09d1dc7..21e1bda 100644 > --- a/teamd/teamd_per_port.c > +++ b/teamd/teamd_per_port.c > @@ -331,6 +331,11 @@ next_one: > return tdport; > } > > +int teamd_port_add(struct teamd_context *ctx, uint32_t ifindex) > +{ > + return team_port_add(ctx->th, ifindex); >...

...ar with how it >handles new interfaces. Also how does this handle existing interfaces >that were registered before you started this? See my reply above. > >> return 0; >> } >> >> diff --git a/teamd/teamd_per_port.c b/teamd/teamd_per_port.c >> index 09d1dc7..21e1bda 100644 >> --- a/teamd/teamd_per_port.c >> +++ b/teamd/teamd_per_port.c >> @@ -331,6 +331,11 @@ next_one: >> return tdport; >> } >> >> +int teamd_port_add(struct teamd_context *ctx, uint32_t ifindex) >> +{ >> + return team...