Displaying 2 results from an estimated 2 matches for "06af237c".
2013 Mar 17
1
Patch to add Unicode filename support for win32 flac
JonY wrote:
> On 3/17/2013 23:01, LRN wrote:
> >> All those ifdefs will at least be confined rather than spread out
> >> through the code.
> > I did it plibc-style:
> >
> > in compat.h:
> > #if defined(_WIN32)
> > #define FOPEN grabbag__fopen_utf8_wrapper
> > #else
> > #define FOPEN fopen
> > #endif
> >
> > in
2013 Mar 18
0
flac-dev Digest, Vol 100, Issue 42
...printf() and localised #ifdef hackery to the
> implementation of that function.
>
> >From a patch cleanliness POV, I like to see the new functionality added in
> one patch and a separate patch to change all the old function usage to the
> new function usage. For example, in commit 06af237c I added the new
> flac_snprintf() function and in commit 3c84f9e8 I replaced all the old
> calls to sprintf/_snprintf.
>
> Cheers,
> Erik
> --
> ----------------------------------------------------------------------
> Erik de Castro Lopo
> http://www.mega-nerd.com/
>
&...