search for: 060532

...ems for many of our >> reviewers. >> Thanks, >> Gordon > > Ok, did I get it right this time? Looks ok, I applied it here: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080331/060531.html http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080331/060532.html I removed the "negative or equal" aspect to the shift amount discussion. Shift amounts are interpreted as unsigned values, so they can't be negative. Also, it looks like your copy of langref is slightly out of date, because the patch didn't apply cleanly. -Chris

Gordon Henriksen wrote: > Hi Jon, > > Please you'll want to submit patches as unified diffs and as > attachments. > > I notice you're using Thunderbird, so I refer you to this tip: > > http://lists.cs.uiuc.edu/pipermail/llvmdev/2008-January/011992.html > > Although this note doesn't apply to how you included your original > patch (looks like you

...> reviewers. >>> Thanks, >>> Gordon >> Ok, did I get it right this time? > > Looks ok, I applied it here: > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080331/060531.html > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080331/060532.html > > I removed the "negative or equal" aspect to the shift amount > discussion. Shift amounts are interpreted as unsigned values, so they > can't be negative. Ah, I didn't see that in the documentation. I suggest adding "Shift amounts are interpreted...