search for: 052bbf12c

...ith this > patch) is: > > libguestfs: error: lvm_canonical_lv_name: /dev/mapper/cryptsda2: not a logical volume > --- > lib/canonical-name.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/canonical-name.c b/lib/canonical-name.c > index 052bbf12c..11cf6fed6 100644 > --- a/lib/canonical-name.c > +++ b/lib/canonical-name.c > @@ -46,8 +46,9 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) > } > else if (STRPREFIX (device, "/dev/mapper/") || > STRPREFIX (device, "/dev/dm...

...error in that specific case. (Even in >this case the underlying error message still gets logged in debug >output). >--- > lib/canonical-name.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/lib/canonical-name.c b/lib/canonical-name.c >index 052bbf12c..e0c7918b4 100644 >--- a/lib/canonical-name.c >+++ b/lib/canonical-name.c >@@ -46,9 +46,14 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) > } > else if (STRPREFIX (device, "/dev/mapper/") || > STRPREFIX (device, "/dev/dm-&quo...

Fixes “XXX” comment. This turns out to be necessary in order to suppress a warning when inspecting Windows BitLocker-encrypted guests. --- lib/canonical-name.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/canonical-name.c b/lib/canonical-name.c index 052bbf12c..11cf6fed6 100644 --- a/lib/canonical-name.c +++ b/lib/canonical-name.c @@ -46,8 +46,9 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) } else if (STRPREFIX (device, "/dev/mapper/") || STRPREFIX (device, "/dev/dm-")) { - /* XXX hide e...

...hich still appears in debugging output even with this patch) is: libguestfs: error: lvm_canonical_lv_name: /dev/mapper/cryptsda2: not a logical volume --- lib/canonical-name.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/canonical-name.c b/lib/canonical-name.c index 052bbf12c..11cf6fed6 100644 --- a/lib/canonical-name.c +++ b/lib/canonical-name.c @@ -46,8 +46,9 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) } else if (STRPREFIX (device, "/dev/mapper/") || STRPREFIX (device, "/dev/dm-")) { - /* XXX hide e...

...ious commit we can now hide that error in that specific case. (Even in this case the underlying error message still gets logged in debug output). --- lib/canonical-name.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/canonical-name.c b/lib/canonical-name.c index 052bbf12c..e0c7918b4 100644 --- a/lib/canonical-name.c +++ b/lib/canonical-name.c @@ -46,9 +46,14 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) } else if (STRPREFIX (device, "/dev/mapper/") || STRPREFIX (device, "/dev/dm-")) { - /* XXX hide...

Original version linked from here: https://bugzilla.redhat.com/show_bug.cgi?id=1808977#c8 There is no change in the code in this series, but feedback from the original series was we shouldn't lose the error message in patch 7. When I tested this just now in fact we don't lose the error if debugging is enabled, but I have updated the commit message to note what the error message is in the

These commits, along with the associated changes to common: https://www.redhat.com/archives/libguestfs/2020-March/msg00286.html support the transparent decryption and inspection of Windows guests encrypted with BitLocker encryption. To do the BitLocker decryption requires cryptsetup 2.3.0 (although cryptsetup 2.3 is not required for existing LUKS use). It also requires a new-ish Linux kernel, I

As discussed in the emails today, this is the third version addressing most points from the v1/v2 review. You will need to pair this with the changes in libguestfs-common from this series: https://www.redhat.com/archives/libguestfs/2020-September/msg00050.html Rich.