search for: 03u

My static checker complains that this sprintf() can overflow but really it can't. Just silence the warning by using snprintf(). Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: the overflow is not possible so just leave the buffer size alone and silence the warning with snprintf(). diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index

My static checker complains that this sprintf() can overflow but really it can't. Just silence the warning by using snprintf(). Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: the overflow is not possible so just leave the buffer size alone and silence the warning with snprintf(). diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index

...port's state at any time > */ > - sprintf(debugfs_name, "vport%up%u", > - port->portdev->vdev->index, id); > + snprintf(debugfs_name, sizeof(debugfs_name), "vport%up%u", > + port->portdev->vdev->index, id); would it help to use %03u (or so) to make it more obvious ? Note: i prefer a leading 0 in my programms to make it more easy to work with grep and friends. you may thing otherwise. re, wh > port->debugfs_file = debugfs_create_file(debugfs_name, 0444, > pdrvdata.debugfs_dir, > port, >...

...sts and everything seemed good so I pushed it out. Since then, all my puppet clients are failing with this: Error: Could not retrieve catalog from remote server: Error 400 on SERVER: undefined method `[]'' for nil:NilClass at /etc/puppet/modules/site/manifests/init.pp:7 on node maps-cs-vm-03u.streamsage.com Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run Googling shows that this is a common error that crops up for any number of reasons. I wonder what my reason is in this case. I use Cobbler as my ENC, so I have no node statements. Since I...

...remainder = do_div(blk_size, divisor[units]); > + i++; > + } > > - if (j) { > - remainder *= 1000; > - remainder /= divisor[units]; > - snprintf(tmp, sizeof(tmp), ".%03u", remainder); > - tmp[j+1] = '\0'; > - } > + exp = divisor[units]; > + do_div(exp, blk_size); > + if (size >= exp) { > + remainder = do_div(size, divisor[units]); > + remainder *=...

...remainder = do_div(blk_size, divisor[units]); > + i++; > + } > > - if (j) { > - remainder *= 1000; > - remainder /= divisor[units]; > - snprintf(tmp, sizeof(tmp), ".%03u", remainder); > - tmp[j+1] = '\0'; > - } > + exp = divisor[units]; > + do_div(exp, blk_size); > + if (size >= exp) { > + remainder = do_div(size, divisor[units]); > + remainder *=...

...*/ > > - sprintf(debugfs_name, "vport%up%u", > > - port->portdev->vdev->index, id); > > + snprintf(debugfs_name, sizeof(debugfs_name), "vport%up%u", > > + port->portdev->vdev->index, id); > > > would it help to use %03u (or so) to make it more obvious ? > > Note: i prefer a leading 0 in my programms to make it more easy > to work with grep and friends. you may thing otherwise. That's an user API change so it's probably a bad idea. regards, dan carpenter

...*/ > > - sprintf(debugfs_name, "vport%up%u", > > - port->portdev->vdev->index, id); > > + snprintf(debugfs_name, sizeof(debugfs_name), "vport%up%u", > > + port->portdev->vdev->index, id); > > > would it help to use %03u (or so) to make it more obvious ? > > Note: i prefer a leading 0 in my programms to make it more easy > to work with grep and friends. you may thing otherwise. Well we've been exposing names like /dev/vport0p0, /dev/vport2p15, etc., and there might be scripts relying on such names, s...

...sprintf(debugfs_name, "vport%up%u", >>> - port->portdev->vdev->index, id); >>> + snprintf(debugfs_name, sizeof(debugfs_name), "vport%up%u", >>> + port->portdev->vdev->index, id); >> >> >> would it help to use %03u (or so) to make it more obvious ? >> >> Note: i prefer a leading 0 in my programms to make it more easy >> to work with grep and friends. you may thing otherwise. > > Well we've been exposing names like /dev/vport0p0, /dev/vport2p15, > etc., and there might be script...

...sprintf(debugfs_name, "vport%up%u", >>> - port->portdev->vdev->index, id); >>> + snprintf(debugfs_name, sizeof(debugfs_name), "vport%up%u", >>> + port->portdev->vdev->index, id); >> >> >> would it help to use %03u (or so) to make it more obvious ? >> >> Note: i prefer a leading 0 in my programms to make it more easy >> to work with grep and friends. you may thing otherwise. > > Well we've been exposing names like /dev/vport0p0, /dev/vport2p15, > etc., and there might be script...

...NODEV; printk("Using HPET for gettimeofday\n"); + init_xtime_from_cmos(); if (cpu_has_tsc) { unsigned long tsc_quotient = calibrate_tsc_hpet(&tsc_hpet_quotient); if (tsc_quotient) { @@ -168,7 +136,7 @@ static int __init init_hpet(char* overri printk("Detected %u.%03u MHz processor.\n", cpu_khz / 1000, cpu_khz % 1000); } - set_cyc2ns_scale(cpu_khz); + set_cyc_scales(cpu_khz); } /* set this only when cpu_has_tsc */ timer_hpet.read_timer = read_timer_tsc; Index: linux-2.6.16-rc6/arch/i386/kernel/timers/timer_pit.c ======================...

...NODEV; printk("Using HPET for gettimeofday\n"); + init_xtime_from_cmos(); if (cpu_has_tsc) { unsigned long tsc_quotient = calibrate_tsc_hpet(&tsc_hpet_quotient); if (tsc_quotient) { @@ -168,7 +136,7 @@ static int __init init_hpet(char* overri printk("Detected %u.%03u MHz processor.\n", cpu_khz / 1000, cpu_khz % 1000); } - set_cyc2ns_scale(cpu_khz); + set_cyc_scales(cpu_khz); } /* set this only when cpu_has_tsc */ timer_hpet.read_timer = read_timer_tsc; Index: linux-2.6.16-rc6/arch/i386/kernel/timers/timer_pit.c ======================...

...for_each_cpu(i) { + /* Shouldn't go idle now, so no extra synchronization needed. */ + unsigned int irqs_per_ks = 0; + if (per_cpu(vmi_idle_no_hz_jiffies, i)) + irqs_per_ks = 1000 * HZ * per_cpu(vmi_idle_no_hz_irqs, i) / + per_cpu(vmi_idle_no_hz_jiffies, i); + seq_printf(m, " %u.%03u", irqs_per_ks/1000, irqs_per_ks%1000); + } + seq_printf(m, "\n"); + } +#endif return 0; } Index: linux-2.6.16-rc6/kernel/sysctl.c =================================================================== --- linux-2.6.16-rc6.orig/kernel/sysctl.c 2006-03-12 19:49:58.000000000 -0800 +++...

...for_each_cpu(i) { + /* Shouldn't go idle now, so no extra synchronization needed. */ + unsigned int irqs_per_ks = 0; + if (per_cpu(vmi_idle_no_hz_jiffies, i)) + irqs_per_ks = 1000 * HZ * per_cpu(vmi_idle_no_hz_irqs, i) / + per_cpu(vmi_idle_no_hz_jiffies, i); + seq_printf(m, " %u.%03u", irqs_per_ks/1000, irqs_per_ks%1000); + } + seq_printf(m, "\n"); + } +#endif return 0; } Index: linux-2.6.16-rc6/kernel/sysctl.c =================================================================== --- linux-2.6.16-rc6.orig/kernel/sysctl.c 2006-03-12 19:49:58.000000000 -0800 +++...

Unlike full virtualization in which the virtual machine provides the same platform interface as running natively on the hardware, paravirtualization requires modification to the guest operating system to work with the platform interface provided by the hypervisor. Xen was designed with performance in mind. Calls to the hypervisor are minimized, batched if necessary, and non-critical codepaths

This patch series implements the Linux Xen guest in terms of the paravirt-ops interface. The features in implemented this patch series are: * domU only * UP only (most code is SMP-safe, but there's no way to create a new vcpu) * writable pagetables, with late pinning/early unpinning (no shadow pagetable support) * supports both PAE and non-PAE modes * xen console * virtual block

This patch series implements the Linux Xen guest in terms of the paravirt-ops interface. The features in implemented this patch series are: * domU only * UP only (most code is SMP-safe, but there's no way to create a new vcpu) * writable pagetables, with late pinning/early unpinning (no shadow pagetable support) * supports both PAE and non-PAE modes * xen console * virtual block

This patch series implements the Linux Xen guest in terms of the paravirt-ops interface. The features in implemented this patch series are: * domU only * UP only (most code is SMP-safe, but there's no way to create a new vcpu) * writable pagetables, with late pinning/early unpinning (no shadow pagetable support) * supports both PAE and non-PAE modes * xen console * virtual block

Hi Andi, This patch series implements the Linux Xen guest as a paravirt_ops backend. The features in implemented this patch series are: * domU only * UP only (most code is SMP-safe, but there's no way to create a new vcpu) * writable pagetables, with late pinning/early unpinning (no shadow pagetable support) * supports both PAE and non-PAE modes * xen hvc console (console=hvc0) *

Hi Andi, This patch series implements the Linux Xen guest as a paravirt_ops backend. The features in implemented this patch series are: * domU only * UP only (most code is SMP-safe, but there's no way to create a new vcpu) * writable pagetables, with late pinning/early unpinning (no shadow pagetable support) * supports both PAE and non-PAE modes * xen hvc console (console=hvc0) *