search for: 02e2060b9

https://bugzilla.redhat.com/show_bug.cgi?id=1564983 Because Mount.mount_vfs was declared with the wrong type signature it could never be called correctly from outside the daemon. The root cause of this problem is that the generator doesn't generate the type signatures automatically (which it could do, and fairly easily). Therefore there are probably other similar bugs waiting to be found.

...uot;^/dev/(?:h|s|v)d.[1234]$" let rec inspect_os () = - Mount.umount_all (); + Mount_utils.umount_all (); (* Iterate over all detected filesystems. Inspect each one in turn. *) let fses = Listfs.list_filesystems () in diff --git a/daemon/inspect_fs.ml b/daemon/inspect_fs.ml index 02e2060b9..da98946af 100644 --- a/daemon/inspect_fs.ml +++ b/daemon/inspect_fs.ml @@ -55,7 +55,7 @@ let rec check_for_filesystem_on mountable vfs_type = if not mounted then None else ( let role = check_filesystem mountable in - Mount.umount_all (); + Mount_utils.umount_al...

Hi, as a followup for the signature fix for mount_vfs [1], here it is a patch series to generate automatically all the OCaml interfaces of daemon actions. [1] https://www.redhat.com/archives/libguestfs/2018-April/msg00059.html Thanks, Pino Toscano (5): daemon: directly use Optgroups daemon: use the structs from the Structs module daemon: move Lvm.lv_canonical to new Lvm_utils module