search for: 023835

...s16 issue cannot be done with a couple of 4 line patches. > The code to fix was originally ported to C from the assembler of a previous SL version, and it > never really worked before; it was needed re-writing certain parts. > Now the new code ( http://www.syslinux.org/archives/2015-July/023835.html ) has been > tested and it does work (you can see an lss16 image in your terminal). I always prefer start > fixing things from a working code base than start patching one that never did. > > if you want to continue with the task probably it's more valuable if you try to tack...

On Sat, 2015-08-22 at 00:56 -0700, Patrick Masotta wrote: > Please take a moment and see what the quoted code does; it'll save you lot of time. I wrote my versions before I knew about the other code. Unfortunately, that other code is a massive single patch and would be hard to review since it would be difficult to bisect should a bug be introduced. I will try to split the other patch

We recently have upgraded syslinux and have noticed that the boot logo code via boot.txt no longer works. I have a couple patches that get it close to working but I appear to be having trouble with color maps. Is there someone would want to help me finish figuring this out? Any interest in the patches I have to fix the rle decoder?

...to be having trouble with color maps. Is > there someone would want to help me finish figuring this out? > > Any interest in the patches I have to fix the rle decoder? > Certainly, there are some of us interested. This might be relevant: http://www.syslinux.org/archives/2015-July/023835.html Sharing patches is very much appreciated. TIA, Ady. > _______________________________________________ > Syslinux mailing list > Submissions to Syslinux at zytor.com > Unsubscribe or set options at: > http://www.zytor.com/mailman/listinfo/syslinux >

...; > there someone would want to help me finish figuring this out? > > > > Any interest in the patches I have to fix the rle decoder? > > > > Certainly, there are some of us interested. > > This might be relevant: > http://www.syslinux.org/archives/2015-July/023835.html Cool. I didn't know about that work. I will need to see what he did with respect to the handling programming the VGA graphics. > Sharing patches is very much appreciated. See following messages.

On Fri, 2015-08-21 at 12:33 -0700, Patrick Masotta wrote: > I think probably this patch is buggy: > > You have redefined VGAFilePtr > > -__export uint16_t *VGAFilePtr; /* Pointer into VGAFileBuf */ > +__export char *VGAFilePtr; /* Pointer into VGAFileBuf */ > > but you did not redefine i.e. > > *VGAFilePtr++ = data; > > Incrementing a

...ed to an integer number of bytes. The rle length needs to be able to hold values > 255. Signed-off-by: Chas Williams <3chas3 at gmail.com> <<<< I think this change is also already included in the patch quoted previously by Ady http://www.syslinux.org/archives/2015-July/023835.html -static inline char getnybble(void) +static inline char getnybble(uint8_t* last_nybble) { - char data = getc(fd); - if (data & 0x10) { - data &= 0x0F; - return data; - } + char data; + + if (*last_nybble & 0x10) +...

...solving the lss16 issue cannot be done with a couple of 4 line patches. The code to fix was originally ported to C from the assembler of a previous SL version, and it never really worked before; it was needed re-writing certain parts. Now the new code ( http://www.syslinux.org/archives/2015-July/023835.html ) has been tested and it does work (you can see an lss16 image in your terminal). I always prefer start fixing things from a working code base than start patching one that never did. if you want to continue with the task probably it's more valuable if you try to tackle the associated is...

getnybble() needs to return four bits at a time from every byte. During rle decode, rows are rounded to an integer number of bytes. The rle length needs to be able to hold values > 255. Signed-off-by: Chas Williams <3chas3 at gmail.com> --- core/graphics.c | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/core/graphics.c