search for: 01da1c3

This was not permitted by the API before, but would in some circumstances work. --- generator/generator | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/generator/generator b/generator/generator index 7f97163..01da1c3 100755 --- a/generator/generator +++ b/generator/generator @@ -3664,6 +3664,16 @@ let generate_lib_api_c () = in List.iter ( function + | Closure { cbname } -> + let value = match errcode with + | Some value -> value + | None -> assert fals...

...ck to take an OClosure instead of a Closure). Requires completion_callback to be non-NULL, but we relax that restriction by moving to OClosure. ACK. Yes, the first four can be applied no matter what else we discuss. > diff --git a/generator/generator b/generator/generator > index 7f97163..01da1c3 100755 > --- a/generator/generator > +++ b/generator/generator > @@ -3664,6 +3664,16 @@ let generate_lib_api_c () = > in > List.iter ( > function > + | Closure { cbname } -> > + let value = match errcode with > + | Some value -&g...

An optional Closure parameter, but otherwise works the same way as Closure. --- generator/generator | 54 ++++++++++++++++++++++++++++++++++++--------- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/generator/generator b/generator/generator index 01da1c3..3add9a4 100755 --- a/generator/generator +++ b/generator/generator @@ -867,6 +867,7 @@ and arg = | UInt32 of string (* 32 bit unsigned int *) | UInt64 of string (* 64 bit unsigned int *) and optarg = +| OClosure of closure (* optional closure *) | OFlags of string * flags...

Patches 1-4 are basically uncontroversial, straightforward refactoring and IMHO we should just push them. Possibly 1-3 should be squashed together, but I posted them separately so they are easier to review. Patches 5 and 6 together implement OClosure. Patch 5 adds the feature and is simple to understand. Patch 6 changes the Closure completion callbacks into OClosure, but because it doesn't