samba - Mar 2025 - Samba 4.22 breaks Time Machine

> On Mar 10, 2025, at 05:15, Ralph Boehme via samba <samba at
lists.samba.org> wrote:
> 
> On 3/9/25 5:14 AM, jdistler-samba--- via samba wrote:
>> Time Machine on macOS relies on fruit:posix_rename (in particular to
>> rename the .sparsebundle file). Samba 4.22 removed this feature,
>> thus breaking Time Machine.
> sorry, but this option was removed as a) it could result in data loss for
Windows clients and b) it was putting a unbearable burden on development.
Could we at least agree that the warning in the Samba 4.22.0 Release Notes:
>> As a possible workaround it is possible to prevent creation of
.DS_Store files
>> (a Finder thingy to store directory view settings) on network mounts by
running
>> 
>> $ defaults write com.apple.desktopservices DSDontWriteNetworkStores
true
>> 
>> on the Mac.
is ... inadequate?

  "Samba 4.22.0 (and later) is therefore incompatible with all current
(macOS 15.x and earlier) versions of Apple's Time Machine."

is the minimal warning that should be in the Release Notes of 4.22.1.
> The correct fix for this would be getting Apple to implement and use SMB3
POSIX Extensions which would cover this case correctly.
Perhaps there will be a future version of macOS which will do that.

Warning users that this change will break all *existing* Time Machine clients is
the least you could do ...

>> 
> Sorry!
> -slow
> -- 
> To unsubscribe from this list go to the following URL and read the
> instructions:  https://lists.samba.org/mailman/options/samba

On 3/10/25 1:59 PM, jdistler-samba at golem.ph.utexas.edu
wrote:
> 
> 
>> On Mar 10, 2025, at 05:15, Ralph Boehme via samba <samba at
lists.samba.org> wrote:
>>
>> On 3/9/25 5:14 AM, jdistler-samba--- via samba wrote:
>>> Time Machine on macOS relies on fruit:posix_rename (in particular
to
>>> rename the .sparsebundle file). Samba 4.22 removed this feature,
>>> thus breaking Time Machine.
>> sorry, but this option was removed as a) it could result in data loss
for Windows clients and b) it was putting a unbearable burden on development.
> 
> Could we at least agree that the warning in the Samba 4.22.0 Release Notes:
> 
>>> As a possible workaround it is possible to prevent creation of
.DS_Store files
>>> (a Finder thingy to store directory view settings) on network
mounts by running
>>>
>>> $ defaults write com.apple.desktopservices DSDontWriteNetworkStores
true
>>>
>>> on the Mac.
> 
> is ... inadequate?
> 
>    "Samba 4.22.0 (and later) is therefore incompatible with all
current (macOS 15.x and earlier) versions of Apple's Time Machine."
> 
> is the minimal warning that should be in the Release Notes of 4.22.1.
yeah, I get it. :) Sorry, but this wasn't clear when the decision had to 
  be made.

Unfortunately there are no release notes coming with bugfix releases. I 
guess all we can do is file a bugreport and hope folks will find this 
thread.

Can you try the attached completely untested patch? It should fix the 
rename issue and from quickly scanning the code it shouldn't have 
unwanted side effects, at least not on a Time Machine only share.

-slow
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fruit-posix.patch
Type: text/x-patch
Size: 773 bytes
Desc: not available
URL:
<http://lists.samba.org/pipermail/samba/attachments/20250310/e79a79c5/fruit-posix.bin>