samba - Oct 2024 - Best way to get the current PDC emulator master via DNS (Possible bug?)

On 22/10/24 08:28, Rowland Penny via samba wrote:
> On Mon, 21 Oct 2024 18:58:55 +0000
> Darin via samba <samba at lists.samba.org> wrote:
> 
>>> Transferring the PDC_Emulator FSMO role does not create the dns
>>> entry,
>> it is created by samba_dnsupdate, which is run every 10 minutes.
>>
>> Is there a reason it doesn't clean up the old one? It seems odd to
>> have multiple DNS entries.
>>
> 
> OK, the reason is, it wasn't added when the initial python code was
> written and I never thought about it when I upgraded the code to
> transfer/seize all 7 FSMO roles. Subsequently, I was told my python
> code isn't really good enough for Samba, so I have no compulsion to fix
> it.
Could you add a bugzilla bug for this? Not your python I mean, or 
people's opinions thereof, but the samba_dnsupdate issue.

Douglas

On Thu, 24 Oct 2024 11:07:34 +1300
Douglas Bagnall via samba <samba at lists.samba.org> wrote:
> On 22/10/24 08:28, Rowland Penny via samba wrote:
> > On Mon, 21 Oct 2024 18:58:55 +0000
> > Darin via samba <samba at lists.samba.org> wrote:
> > 
> >>> Transferring the PDC_Emulator FSMO role does not create the
dns
> >>> entry,
> >> it is created by samba_dnsupdate, which is run every 10 minutes.
> >>
> >> Is there a reason it doesn't clean up the old one? It seems
odd to
> >> have multiple DNS entries.
> >>
> > 
> > OK, the reason is, it wasn't added when the initial python code
was
> > written and I never thought about it when I upgraded the code to
> > transfer/seize all 7 FSMO roles. Subsequently, I was told my python
> > code isn't really good enough for Samba, so I have no compulsion
to
> > fix it.
> 
> Could you add a bugzilla bug for this? Not your python I mean, or 
> people's opinions thereof, but the samba_dnsupdate issue.
> 
> Douglas
> 
> 
> 
Hi Douglas,

OK, bug 15747 opened:

https://bugzilla.samba.org/show_bug.cgi?id=15747

Now would you like me to open a bug for this:

samba-tool -V
samba-tool: no such subcommand: -V

Usage: samba-tool <subcommand>
..........

If '-V' isn't a subcommand, then I will eat my hat.

I will even tell you how I fix it:

in samba/netcmd/__init__.py

at line 352, replace:

                continue
With:
                return (self, deferred_args)

Without the 'return' it falls down into:

        # We didn't find a subcommand, but maybe we found e.g. --version
        print("%s: missing subcommand\n" % (path), file=self.outf)
        return (self, deferred_args)

There is probably a better way of fixing it, but it works for me.

Rowland