samba - Nov 2023 - sysvol-reset deletes delegation ACL

Thank you I understand better with the gitlab link.
Failing to have this commit accepted, we should perhaps revert this 
commit which is a regression :

https://gitlab.com/samba-team/samba/-/commit/27dd0afb62d4f7427c966e984c7c8b01bc4d93b5

Simon

Le 13/11/2023 ? 17:30, Ralph Boehme via samba a ?crit?:
> https://bugzilla.samba.org/show_bug.cgi?id=14927
> https://gitlab.com/samba-team/samba/-/merge_requests/2281
>
> Sadly we haven't yet been able to dedicate the required time and 
> resources to implement the missing tests. Iirc we added the patches to 
> out SAMBA+ packages as we were in a hurry back then, but I guess that 
> won't help you. You could take the patches from gitlab if build your 
> own packages if that's an option, they do seem to work correctly.
>
> -slow
>
>

On 11/13/23 17:53, Simon FONTENEAU via samba wrote:
> Thank you I understand better with the gitlab link.
> Failing to have this commit accepted, we should perhaps revert this 
> commit which is a regression :
> 
>
https://gitlab.com/samba-team/samba/-/commit/27dd0afb62d4f7427c966e984c7c8b01bc4d93b5
for certain reasons this is not how development works. :) These days we 
always require tests for all changes. Yes, this sometimes sucks in the 
short term, but this is that ensures quality in the long run.

Maybe one of your engineers can contribute and write a test? That would 
be awesome!

-slow

-- 
SerNet Samba Team Lead          https://samba.plus/
Samba Team Member                https://samba.org/
SAMBA+ packages                 https://samba.plus/
Worldwide Samba Support, Consulting and Development


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.samba.org/pipermail/samba/attachments/20231113/a3405940/OpenPGP_signature.sig>