On 03/08/2023 20:25, Joachim Lindenberg via samba wrote:> I am trying to compile samba for the first time and ran into several issues that might be obvious for all team members but not for me and I think documentation could be improved/updated. > > > > 1. I am wondering why https://wiki.samba.org/index.php/Build_Samba_from_Source suggests to use wget instead of just git clone https://gitlab.com/samba-team/devel/samba.git and then checking out a release branch. Or are these really different?Yes they are different, if you use git, you will either download the latest Samba (which is still being worked on) or a branch that has been packed up and released, in which case it is easier to use wget to download the tarball.> 2. The package dependencies at https://wiki.samba.org/index.php/Package_Dependencies_Required_to_Build_Samba#Debian_/_Ubuntu don?t work well for me. For one I think it would help to update them to (most) recent distributions (I am trying on Ubuntu 22.04.2), but I believe I managed that part.Did you miss this line: This list is for older Samba versions (4.10 and earlier) and distributions not included in the table above Though that could be better, 22.04 isn't in the table above, so use 20.04, that will be a lot nearer than the manual list. Rowland
On Thu, 2023-08-03 at 20:37 +0100, Rowland Penny via samba wrote:> This list is for older Samba versions (4.10 and earlier) and > distributions not included in the table above > > > Though that could be better, 22.04 isn't in the table above, so use > 20.04, that will be a lot nearer than the manual list.The scripts all exist, but the table hasn't been updated to link to them. I think the table wasn't my best idea in hindsight. It is hard to update (I locked it to administrator so someone wouldn't be able to link to a malicious script) and has to be updated each release. Better would be to remove the table (the whole wiki include) and replace it with text explaining how to find the script in the source tree - if the user is building Samba, clearly they have the source code! If you have any time to do that it would be awesome. Thanks, Andrew -- Andrew Bartlett (he/him) https://samba.org/~abartlet/Samba Team Member (since 2001) https://samba.orgSamba Team Lead https://catalyst.net.nz/services/sambaCatalyst.Net Ltd Proudly developing Samba for Catalyst.Net Ltd - a Catalyst IT group company Samba Development and Support: https://catalyst.net.nz/services/samba Catalyst IT - Expert Open Source Solutions
In response to Rowland?s mail:>> 1. I am wondering why https://wiki.samba.org/index.php/Build_Samba_from_Source suggests to use wget instead of just git clone https://gitlab.com/samba-team/devel/samba.git >>and then checking out a release branch. Or are these really different?>Yes they are different, if you use git, you will either download the latest Samba (which is still being worked on) or a branch that has been packed up and released, in which case it is >easier to use wget to download the tarball.samba-4.18.5.tar.gz differs from branch 4.18.5 ?? When do you tag what? In response to Andrew?s mail:>The scripts all exist, but the table hasn't been updated to link to them. >I think the table wasn't my best idea in hindsight. It is hard to update (I locked it to administrator so someone wouldn't be able to link to a malicious script) and has to be updated each >release.In other words, the pointer in https://wiki.samba.org/index.php/Build_Samba_from_Source# "Compiling Samba requires only a few steps: Install all dependencies. See Package Dependencies Required to Build Samba." could be replaced by get sources first, cd to bootstrap/generated-dists/<distrowithversion>, execute bootstrap.sh get deps? I tried, and configure returned success. I am willing to update https://wiki.samba.org/index.php/Build_Samba_from_Source if you agree.. Thanks, Joachim