samba - Mar 2022 - Trouble cross compiling samba 4.15.5 with glibc 2.11. Problem with samba-bgqd.c

On Mon, 2022-03-14 at 10:29 +1100, Berto Furth via samba
wrote:
> 
> Do you think that if I raised a samba bug that there'd be any hope of
> getting this include statement added to samba-bgqd.c ? Can anyone
> suggest something else that might be more elegant to resolve this
> issue with compiling samba using glibc 2.11?
As a general rule, we don't include any system headers in our main C
files, we have headers in lib/replace that we include, so either
include the 'right' header from there or put the extra include, guarded
appropriately in a header there.

Then raise a MR I guess: https://wiki.samba.org/index.php/Contribute

Andrew,

-- 
Andrew Bartlett (he/him)       https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Team Lead, Catalyst IT   https://catalyst.net.nz/services/samba

Samba Development and Support, Catalyst IT - Expert Open Source
Solutions

On Mon, 2022-03-14 at 12:55 +1300, Andrew Bartlett via samba
wrote:
> On Mon, 2022-03-14 at 10:29 +1100, Berto Furth via samba wrote:
> > Do you think that if I raised a samba bug that there'd be any hope
> > of
> > getting this include statement added to samba-bgqd.c ? Can anyone
> > suggest something else that might be more elegant to resolve this
> > issue with compiling samba using glibc 2.11?
> 
> As a general rule, we don't include any system headers in our main C
> files, we have headers in lib/replace that we include, so either
> include the 'right' header from there or put the extra include,
> guarded
> appropriately in a header there.
> 
> Then raise a MR I guess: https://wiki.samba.org/index.php/Contribute
> 
> Andrew,
Hi Andrew, do we really want to be supporting such an old version of
glibc in any way ? What is the users 'target platform', could it be it
is one that depends on SMBv1, the very thing Samba is working to remove
?

Rowland