Thanks, I'll do that. It might be a week or two. But I have solid C skills going back 25 years, and spent a decade doing C++. Let me know if there's a "getting started guide" for developers on the Samba project. Key tools to install, etc. I will need to spin up a VM to work in. Also, should chat with the CTO so he's aware. On Thu, Nov 12, 2020 at 4:46 AM Martin Schwenke <martin at meltin.net> wrote:> Hi Bob, > > On Wed, 11 Nov 2020 08:10:28 -0500, Robert Buck via samba > <samba at lists.samba.org> wrote: > > > Folks, thank you for being so helpful. > > > > I can't quite figure out the exact command line to get ctdb > > dbstatistics for the locking.tdb in CSV format. How do you do this? > > > > [root at use1-samba-server-c25-use1-01 ec2-user]# ctdb -X --separator=, > > dbstatistics locking.tdb --help > > > > Usage: [OPTION...] > > > [...] > > > -Y enable machine readable output > > > > -x, --separator=CHAR specify separator for machine readable output > > > > -X enable machine parsable output with separator > | > > > [...] > > > No matter where I put "-X -x ," in the command line, it just displays in > > non-machine readable format. > > > > Thoughts? > > Unfortunately it appears that machine readable output has never been > implemented in the ctdb tool. :-( > > With some seriousness I ask: how is your C programming? :-) > This one would be a fairly simple change to the tool, using > print_statistics_machine() as a model. If that's not something you can > do then I can add it to my todo list. > > To get this backported to stable releases it would have to be > considered a bug. To get that process started, can you please open a > bug at https://bugzilla.samba.org/? > > Thanks... > > peace & happiness, > martin > >-- BOB BUCK SENIOR PLATFORM SOFTWARE ENGINEER SKIDMORE, OWINGS & MERRILL 7 WORLD TRADE CENTER 250 GREENWICH STREET NEW YORK, NY 10007 T (212) 298-9624 ROBERT.BUCK at SOM.COM
On Thu, Nov 12, 2020 at 10:26:30AM -0500, Robert Buck via samba wrote:> Thanks, I'll do that. It might be a week or two. But I have solid C skills > going back 25 years, and spent a decade doing C++. > > Let me know if there's a "getting started guide" for developers on the > Samba project. Key tools to install, etc. I will need to spin up a VM to > work in. > > Also, should chat with the CTO so he's aware.You should also get permission from legal to send in the Samba Developer's Declaration: See here: https://www.samba.org/samba/devel/copyright-policy.html for details !
Cool, thanks! Let me pass this along. On Thu, Nov 12, 2020 at 11:42 AM Jeremy Allison <jra at samba.org> wrote:> On Thu, Nov 12, 2020 at 10:26:30AM -0500, Robert Buck via samba wrote: > > Thanks, I'll do that. It might be a week or two. But I have solid C > skills > > going back 25 years, and spent a decade doing C++. > > > > Let me know if there's a "getting started guide" for developers on the > > Samba project. Key tools to install, etc. I will need to spin up a VM to > > work in. > > > > Also, should chat with the CTO so he's aware. > > You should also get permission from legal to send in the > Samba Developer's Declaration: > > See here: > > https://www.samba.org/samba/devel/copyright-policy.html > > for details ! > >-- BOB BUCK SENIOR PLATFORM SOFTWARE ENGINEER SKIDMORE, OWINGS & MERRILL 7 WORLD TRADE CENTER 250 GREENWICH STREET NEW YORK, NY 10007 T (212) 298-9624 ROBERT.BUCK at SOM.COM
Hi Bob, On Thu, 12 Nov 2020 10:26:30 -0500, Robert Buck via samba <samba at lists.samba.org> wrote:> Thanks, I'll do that. It might be a week or two. But I have solid C skills > going back 25 years, and spent a decade doing C++. > > Let me know if there's a "getting started guide" for developers on the > Samba project. Key tools to install, etc. I will need to spin up a VM to > work in. > > Also, should chat with the CTO so he's aware.Sorry that this was left with unanswered questions for so long... The main thing to read would be this: https://wiki.samba.org/index.php/Contribute It links to some other pages that are useful. README.Coding.md at the top of the Samba tree is worth reading. If you're only working on CTDB then you can ./configure and make within the ctdb/ subdirectory. In that case tests/README is worth a scan. For the work on "ctdb dbstatistics" that you were proposing you would probably want to add some tests in tests/UNIT/tool/. I notice that we don't currently have any tests for "ctdb dbstatistics" there. That would actually involve implementing CTDB_CONTROL_GET_DB_STATISTICS in tests/src/fake_ctdb.c. One implementation would be to add reading of canned data when fake ctdbd starts, as occurs with quite a few other controls. peace & happiness, martin