Hi Konstantin, On Wed, 10 Jul 2019, Konstantin Shalygin via samba wrote:> Vincent, excellent work!Thank you. Glad it's helping others.> Can you also provide support for rados vfs (already exists in SPEC) and > ctdb_mutex_ceph_rados_helper?That's probably doable but you'd have to BETA-test for me since I don't have a working ceph cluster at home. The information you've provided is very useful, I'll take a look, probably in the next few days.. Kindest regards, Vincent
On 7/10/19 9:49 PM, vincent at cojot.name wrote:> > That's probably doable but you'd have to BETA-test for me since I > don't have a working ceph cluster at home. The information you've > provided is very useful, I'll take a look, probably in the next few > days..Sure, yesterday I was investigates this SPEC and build packages for myself. Today I think I'll add support for rados features and send diff snippet to you. k
On 7/10/19 9:49 PM, vincent at cojot.name wrote: Attached diff for SPEC. I'm not a rpm (many small packages) lover, so this is may be a dirty solution and should be refactored. Also, when I was setup ctdb this catalogs should be exists [1] ``` mkdir /var/lib/ctdb/volatile mkdir /var/lib/ctdb/state mkdir /var/lib/ctdb/persistent mkdir /etc/ctdb/events/legacy ``` [1] https://bugzilla.redhat.com/show_bug.cgi?id=1656777 k -------------- next part -------------- A non-text attachment was scrubbed... Name: samba-v410x.diff Type: text/x-patch Size: 1774 bytes Desc: not available URL: <http://lists.samba.org/pipermail/samba/attachments/20190711/ecdc0f90/samba-v410x.bin>
Hi Konstantin, Thank you for the diff. I will review it and merge it today. About the missing directories, I think it may be doable to add them to the 'ctdb' rpm. As I'm not using ctdb, what should the ownership/permissions be for those directories? Regards, Vincent On Thu, 11 Jul 2019, Konstantin Shalygin wrote:> On 7/10/19 9:49 PM, vincent at cojot.name wrote: > > > Attached diff for SPEC. I'm not a rpm (many small packages) lover, so this is > may be a dirty solution and should be refactored. > Also, when I was setup ctdb this catalogs should be exists [1] > > ``` > mkdir /var/lib/ctdb/volatile > mkdir /var/lib/ctdb/state > mkdir /var/lib/ctdb/persistent > mkdir /etc/ctdb/events/legacy > ``` > > > > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1656777 > > k > >
Hi Konstantin, I've merged your patch and added the missing directories to the ctdb package. However, I'm not sure I'll be building binary rpms with cephfs enabled as this makes ctdb dependent on ceph (see below). I'm probably going to include it as a non-default option and people will have to rebuild the rpms with '--with vfs_cephfs' [root at dc00 testing]# rpm -Fvh x86_64/*rpm noarch/*rpm error: Failed dependencies: libceph-common.so.0()(64bit) is needed by ctdb-0:4.10.6-2.8.el7.x86_64 librados.so.2()(64bit) is needed by ctdb-0:4.10.6-2.8.el7.x86_64 I'll post an update here when I'm done.. ,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-, Vincent S. Cojot, Computer Engineering. STEP project. _.,-*~'`^`'~*-,._.,-*~ Ecole Polytechnique de Montreal, Comite Micro-Informatique. _.,-*~'`^`'~*-,. Linux Xview/OpenLook resources page _.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~' http://step.polymtl.ca/~coyote _.,-*~'`^`'~*-,._ coyote at NOSPAM4cojot.name They cannot scare me with their empty spaces Between stars - on stars where no human race is I have it in me so much nearer home To scare myself with my own desert places. - Robert Frost On Thu, 11 Jul 2019, Konstantin Shalygin wrote:> On 7/10/19 9:49 PM, vincent at cojot.name wrote: > > > Attached diff for SPEC. I'm not a rpm (many small packages) lover, so this is > may be a dirty solution and should be refactored. > Also, when I was setup ctdb this catalogs should be exists [1] > > ``` > mkdir /var/lib/ctdb/volatile > mkdir /var/lib/ctdb/state > mkdir /var/lib/ctdb/persistent > mkdir /etc/ctdb/events/legacy > ``` > > > > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1656777 > > k > >