samba - Jul 2019 - [Announce] Samba 4.9.10 Available for Download

Quick update, I checked ldb-1.4.x to ldb-1.6.x and couldn't find an 
LDAP_REFERRAL_SCHEME defined anywhere. (Perhaps it's in an un-released 
version).

So, for now a copy of the define from 
ldb_module (source4/dsdb/samdb/ldb_modules/ldb_module.h) will do, I guess:

# cat samba-4.9.10-ldb-scheme.patch
*** samba-4.9.10/source4/include/includes.h.orig        2019-07-02 
14:47:43.008208717 -0400
--- samba-4.9.10/source4/include/includes.h     2019-07-02 
14:48:01.858236975 -0400
***************
*** 73,76 ****
--- 73,79 ----
   /* samba_setXXid functions. */
   #include "../lib/util/setid.h"

+ /* Samba 4.9.10 workaround */
+ #define LDAP_REFERRAL_SCHEME_OPAQUE "LDAP_REFERRAL_SCHEME"
+
   #endif /* _INCLUDES_H */

Regards,

Vincent

On Tue, 2019-07-02 at 14:50 -0400, Vincent S. Cojot via samba
wrote:
> Quick update, I checked ldb-1.4.x to ldb-1.6.x and couldn't find an 
> LDAP_REFERRAL_SCHEME defined anywhere. (Perhaps it's in an un-
> released 
> version).
> 
> So, for now a copy of the define from 
> ldb_module (source4/dsdb/samdb/ldb_modules/ldb_module.h) will do, I
> guess:
> 
> # cat samba-4.9.10-ldb-scheme.patch
> *** samba-4.9.10/source4/include/includes.h.orig        2019-07-02 
> 14:47:43.008208717 -0400
> --- samba-4.9.10/source4/include/includes.h     2019-07-02 
> 14:48:01.858236975 -0400
> ***************
> *** 73,76 ****
> --- 73,79 ----
>    /* samba_setXXid functions. */
>    #include "../lib/util/setid.h"
> 
> + /* Samba 4.9.10 workaround */
> + #define LDAP_REFERRAL_SCHEME_OPAQUE "LDAP_REFERRAL_SCHEME"
> +
>    #endif /* _INCLUDES_H */
> 
> Regards,
> 
> Vincent
Yes, that is what has happened.  It will be in the samba 4.9 git tree,
but because no version increment was done builds on systems that have
ldb from the system will fail.

I did propose a way to strictly avoid this happening, by directly
connecting the Samba and LDB version as the same number, but was unable
to get consensus. 

A future Samba 4.9 and 4.10 release will need to bump the ldb version
to fix this issue.

Sorry,

Andrew Bartlett

-- 
Andrew Bartlett                       https://samba.org/~abartlet/
Authentication Developer, Samba Team  https://samba.org
Samba Developer, Catalyst IT          
https://catalyst.net.nz/services/samba

On Wed, 3 Jul 2019, Andrew Bartlett via samba wrote:
> Yes, that is what has happened.  It will be in the samba 4.9 git tree,
> but because no version increment was done builds on systems that have
> ldb from the system will fail.
Ok, gotcha. Thanks.
> I did propose a way to strictly avoid this happening, by directly
> connecting the Samba and LDB version as the same number, but was unable
> to get consensus.
>
> A future Samba 4.9 and 4.10 release will need to bump the ldb version
> to fix this issue.
No problem but what ldb family should be the target? I've been building 
samba 4.9.x using ldb-1.4.6 (system-wide install), will the new ldb 
release be backported to 1.4.x or should I just update the builds to 
consume something more recent?
> Sorry,
No worries, stuff like that happens in many huge OSS projects. :)

Vincent

> Yes, that is what has happened.  It will be in the samba 4.9 git tree,
> but because no version increment was done builds on systems that have
> ldb from the system will fail.

My version of ldb is "libldb-1.3.4-1.el7.x86_64", which I suppose is
the
stock CentOS 7.6 version.

The first time I buiIt with "--without-ad-dc". I just built it again
as
AD-DC and the build completed without errors.