On 5/23/2019 6:25 PM, Douglas Bagnall wrote:> hi James, > >> @dc1:~# samba-tool dns serverinfo dc1.domain.local -U administrator >> Password for [DOMAIN\administrator]: >> dwVersion : 0xece0205 >> fBootMethod : DNS_BOOT_METHOD_DIRECTORY >> fAdminConfigured : FALSE >> fAllowUpdate : TRUE >> fDsAvailable : TRUE >> pszServerName : DC1.domain.local >> pszDsContainer : >> CN=MicrosoftDNS,DC=DomainDnsZones,DC=domain,DC=local >> ERROR(<class 'TypeError'>): uncaught exception - a bytes-like object is >> required, not 'str' >> File >> "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/__init__.py", >> line 185, in _run >> return self.run(*args, **kwargs) >> File >> "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line >> 564, in run >> print_serverinfo(self.outf, typeid, res) >> File >> "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line >> 225, in print_serverinfo >> dns_addr_array_string(serverinfo.aipServerAddrs)) >> File >> "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line >> 157, in dns_addr_array_string >> addr = inet_ntop(AF_INET, x) >> >> I'm not experiencing any DNS issues so I believe this may be a bug with >> the move to python3 Am I correct? > Yes, you are very likely correct. > > Does the attached patch help? > > If you can confirm this at > https://bugzilla.samba.org/show_bug.cgi?id=13965 > it can get into the next 4.10 release. > > DouglasDouglas, Now I get the following error with the patch applied. samba-tool dns serverinfo dc2 -U administrator Password for [DOMAIN\administrator]: dwVersion : 0xece0205 fBootMethod : DNS_BOOT_METHOD_DIRECTORY fAdminConfigured : FALSE fAllowUpdate : TRUE fDsAvailable : TRUE pszServerName : DC2.domain.local pszDsContainer : CN=MicrosoftDNS,DC=DomainDnsZones,DC=domain,DC=local ERROR(<class 'TypeError'>): uncaught exception - string argument without an encoding File "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/__init__.py", line 185, in _run return self.run(*args, **kwargs) File "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line 567, in run print_serverinfo(self.outf, typeid, res) File "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line 228, in print_serverinfo dns_addr_array_string(serverinfo.aipServerAddrs)) File "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line 159, in dns_addr_array_string x = b"".join(bytes(chr(b)) for b in array.AddrArray[i].MaxSa)[4:8] File "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line 159, in <genexpr> x = b"".join(bytes(chr(b)) for b in array.AddrArray[i].MaxSa)[4:8]
Douglas Bagnall
2019-May-29 02:17 UTC
[Samba] samba-tool dns serverinfo command throws error
On 29/05/19 4:45 AM, James Atwell wrote:>>> "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line >>> 157, in dns_addr_array_string >>> addr = inet_ntop(AF_INET, x) >>> >>> I'm not experiencing any DNS issues so I believe this may be a bug with >>> the move to python3 Am I correct? >> Yes, you are very likely correct. >> >> Does the attached patch help? >> >> If you can confirm this at >> https://bugzilla.samba.org/show_bug.cgi?id=13965 >> it can get into the next 4.10 release. >> >> Douglas > > Douglas, > > Now I get the following error with the patch applied. > [...]OK. THIS time I wrote a test, and it is running in CI. Does this one help? Douglas -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-samba-tool-dns-use-bytes-for-inet_ntop.patch Type: text/x-patch Size: 2039 bytes Desc: not available URL: <http://lists.samba.org/pipermail/samba/attachments/20190529/3f53dee6/0001-samba-tool-dns-use-bytes-for-inet_ntop.bin>
Douglas, That worked! Thank you. On 5/28/2019 10:17 PM, Douglas Bagnall wrote:> On 29/05/19 4:45 AM, James Atwell wrote: > >>>> "/usr/local/samba/lib/python3.5/site-packages/samba/netcmd/dns.py", line >>>> 157, in dns_addr_array_string >>>> addr = inet_ntop(AF_INET, x) >>>> >>>> I'm not experiencing any DNS issues so I believe this may be a bug with >>>> the move to python3 Am I correct? >>> Yes, you are very likely correct. >>> >>> Does the attached patch help? >>> >>> If you can confirm this at >>> https://bugzilla.samba.org/show_bug.cgi?id=13965 >>> it can get into the next 4.10 release. >>> >>> Douglas >> Douglas, >> >> Now I get the following error with the patch applied. >> [...] > OK. THIS time I wrote a test, and it is running in CI. > > Does this one help? > > Douglas