Hmm, i alway typo a mail to see Rowland answered it .. ;-) 
But see below, my addition.. 
> -----Oorspronkelijk bericht-----
> Van: samba [mailto:samba-bounces at lists.samba.org] Namens 
> Rowland Penny via samba
> Verzonden: donderdag 28 februari 2019 11:23
> Aan: samba at lists.samba.org
> Onderwerp: Re: [Samba] 4.7.x -> 4.9.x upgrade
> 
> On Thu, 28 Feb 2019 10:42:54 +0100
> Dario Lesca via samba <samba at lists.samba.org> wrote:
> 
> > Il giorno gio, 14/02/2019 alle 20.22 +0000, Rowland Penny 
> via samba ha
> > scritto:
> > > > if you can't do a dist-upgrade and just reboot it's
a bug
> > > 
> > > We know it is a bug:
> > > https://bugzilla.samba.org/show_bug.cgi?id=13760
> > 
> > I can also update from 4.7.x to 4.8.x, then 4.8.x to 4.9.x.
> > 
> > Also in this case  can occur some problems?
> > 
> > Thanks
> > 
> > 
> 
> I tested this, and updating as you suggested, worked. I note that
> Andrew has now come to the same conclusion as I did, 
> upgrading directly
> from 4.7.x to 4.9.x leads to Samba thinking it is now using the GUID
> mode.
> 
> You could try Andrews suggestion, upgrade directly, then run
'ldbedit'
> on sam.ldb
I was looking for that mail because i think that in stead of 'ldbedit'
on sam.ldb
samba-tool dbcheck --reindex might help also and then this help for 2 things.. 
On you question : > Also in this case  can occur some problems? 
If you hit problems you know where to find us.
Just prepair things before you upgrade.
# make the missing folder in advance. 9
mkdir -p /var/lib/samba/bind-dns/dns
I suggest the following, before you upgrade. 
Stop samba-ad-dc 
# Shown folders are debian based. 
Backup the AD, just tar.gz /var/lib/samba /var/cache/samba /etc/samba ( optional
/etc/bind)
start samba-ad-dc 
Run : samba-tool dbcheck 
(optional samba-tool dbcheck --cross-nc 
Fix things if needed. 
Check replications. 
Check you smb.conf if its compatible with 4.8/4.9 
Upgrade samba, after upgrade, wait until you see that samba relaxs in cpu load. 
Then the AD is upgraded. 
# reindex. 
Samba-tool dbcheck --reindex ( needed on per DC) 
Restart samba-ad-dc 
If you use bind9: 
Yes : restart bind9 samba-ad-dc 	
No  : restart samba-ad-dc bind9 
Check you logs, clean up logs, reboot, check logs. 
Be happy you made it.. 
Greetz, 
Louis