On Thu, 2017-12-14 at 18:52 -0600, Arthur Ramsey wrote:> Thanks Andrew, much better than vanilla 4.7.3 but it is still performs > much worse than vanilla 4.7.0 especially for DLZ zones.I understand. The key issue is that to support the wildcards we changed the way we use the database, the SCOPE_ONELEVEL index (compared with SCOPE_BASE used exclusively in the past) over 7000 possible values is the choke point on the database I'm testing with. This is much improved in master, but sadly the primary fix turns out to be the GUID index change (which is too much to backport), rather than (as I had hoped) the supporting changes. Are the stats you included on the patched 4.7.3, or the original release? Thanks, Andrew Bartlett -- Andrew Bartlett https://samba.org/~abartlet/ Authentication Developer, Samba Team https://samba.org Samba Development and Support, Catalyst IT https://catalyst.net.nz/services/samba
Patched. I can repeat test with vanilla if you like but it was much worse. The mean was probably ~1750ms, the stdev ~1000ms and the max > 3000ms. On 12/14/2017 7:52 PM, Andrew Bartlett wrote:> Are the stats you included on the patched 4.7.3, or the original > release?This e-mail and any attachments may contain CONFIDENTIAL information, including PROTECTED HEALTH INFORMATION. If you are not the intended recipient, any use or disclosure of this information is STRICTLY PROHIBITED; you are requested to delete this e-mail and any attachments, notify the sender immediately, and notify the Mediture Privacy Officer at privacyofficer at mediture.com.
Can you provide a reference to the "GUID index change" commit so I can more easily track when it gets included in a stable release? Currently targeted for 4.8.0? On 12/14/2017 7:52 PM, Andrew Bartlett wrote:> This is much improved in master, but sadly the primary fix turns out to > be the GUID index change (which is too much to backport), rather than > (as I had hoped) the supporting changes.This e-mail and any attachments may contain CONFIDENTIAL information, including PROTECTED HEALTH INFORMATION. If you are not the intended recipient, any use or disclosure of this information is STRICTLY PROHIBITED; you are requested to delete this e-mail and any attachments, notify the sender immediately, and notify the Mediture Privacy Officer at privacyofficer at mediture.com.
On Thu, 2017-12-14 at 20:17 -0600, Arthur Ramsey via samba wrote:> Can you provide a reference to the "GUID index change" commit so I can > more easily track when it gets included in a stable release? Currently > targeted for 4.8.0?Yes, the GUID index change, which combined with a change to the way we handle SCOPE_ONELEVEL indexed queries is the best fix for this issue. These changes are all in master. However we were able to devise a backportable fix to the index code and we have proposed that for 4.7. It changes the index code in a different way, one that is much more limited and so more appropriate for the backport. With this the critical 'not found' response time is returned to at around 20ms. I'm currently working to get that approved for release in 4.7.4, however the patches I proposed have been objected to. As such, I can't tell you when this will be resolved or Samba 4.7.4 will be released, but I hope it is soon. Feel free to CC yourself to the bug: https://bugzilla.samba.org/show_bug.cgi?id=13191 I'll continue to make the case for getting this fixed as soon as possible. Thanks, Andrew Bartlett -- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba