samba - Jun 2017 - Lowercase characters on GPO IDs in Samba source files

Turns out that I was at least half-right, after all.

I just opened the files contained in the last Samba release (contained 
in samba-4.6.5.tar.gz) and although the typos have been corrected in 
"./python/samba/provision/__init__.py", *they are still there* in 
"./examples/misc/adssearch.pl" and "./libgpo/gpo_util.c".

It happened that, before my first post, I had peeked into 
"./examples/misc/adssearch.pl" and it was there, that's why I
posted.

Can we solve this very simple matter once and for all? If I can help in 
any way, I will gladly do it.

On Wed, 28 Jun 2017 21:44:05 +0100
Miguel Medalha via samba <samba at lists.samba.org> wrote:
> Turns out that I was at least half-right, after all.
> 
> I just opened the files contained in the last Samba release
> (contained in samba-4.6.5.tar.gz) and although the typos have been
> corrected in "./python/samba/provision/__init__.py", *they are
still
> there* in "./examples/misc/adssearch.pl" and
"./libgpo/gpo_util.c".
> 
> It happened that, before my first post, I had peeked into 
> "./examples/misc/adssearch.pl" and it was there, that's why I
posted.
> 
> Can we solve this very simple matter once and for all? If I can help
> in any way, I will gladly do it.
> 
OK, "6AC1786C-016F-11D2-945F-00C04fB984F9" is in 'adssearch.pl,
this
probably needs fixing, but is not actually a priority, as I don't think
anybody actually uses that file.

"6AC1786C-016F-11D2-945F-00C04fB984F9" is also in gpo_util.c but
I don't really think it needs fixing because this is the code it is in:

#if 0 /* unused */
static struct gp_table gpo_default_policy[] = {
	{ DEFAULT_DOMAIN_POLICY,
		"31B2F340-016D-11D2-945F-00C04FB984F9" },
	{ DEFAULT_DOMAIN_CONTROLLERS_POLICY,
		"6AC1786C-016F-11D2-945F-00C04fB984F9" },
	{ NULL, NULL }
};
#endif

As you quite clearly see, that block of code is unused.

Do they need fixing Jeremy ?
If so, I will create patches.

Rowland

Last year, when I noticed the typos, I created patches for my own use. I 
don't know if they meet your standards, but I include them as 
attachments nevertheless. Maybe they are useful.


-------------- next part --------------
--- a/examples/misc/adssearch.pl	2016-01-26 11:45:46.000000000 +0000
+++ b/examples/misc/adssearch.pl	2016-04-24 22:09:42.525284667 +0100
@@ -354,7 +354,7 @@
 
 my %ads_gpo_default_guids = (
 "Default Domain Policy"			=>
"31B2F340-016D-11D2-945F-00C04FB984F9",
-"Default Domain Controllers Policy"	=>
"6AC1786C-016F-11D2-945F-00C04fB984F9",
+"Default Domain Controllers Policy"	=>
"6AC1786C-016F-11D2-945F-00C04FB984F9",
 "mist"					=> "61718096-3D3F-4398-8318-203A48976F9E",
 );
 
-------------- next part --------------
--- a/libgpo/gpo_util.c	2016-01-26 11:45:46.000000000 +0000
+++ b/libgpo/gpo_util.c	2016-04-24 22:10:59.062270409 +0100
@@ -43,7 +43,7 @@
 	{ DEFAULT_DOMAIN_POLICY,
 		"31B2F340-016D-11D2-945F-00C04FB984F9" },
 	{ DEFAULT_DOMAIN_CONTROLLERS_POLICY,
-		"6AC1786C-016F-11D2-945F-00C04fB984F9" },
+		"6AC1786C-016F-11D2-945F-00C04FB984F9" },
 	{ NULL, NULL }
 };
 #endif