On 8/22/2016 9:55 AM, Marc Muehlfeld wrote:> > > Are you asking because of a patch you're missing in a release? > > > > Regards, > MarcNo. This is the first time I have applied a patch to Samba. Seeing as how I find this particular patch as critical for my environment, I didn't want to inadvertently break DNS updates on my next Samba update. This patch shows two attachments. One for 4.3 and one for 4.4 cherry picked from master. I take this as anytime someone updates 4.3 to a new revision, they must apply this patch unless it's stated in a release note. With respect to 4.4 cherry picked from master. I take this as any revision update to 4.4, one must apply this patch unless stated in the release notes. Going forward with 4.5 this patch is already included. A bit confusing for me and wanted clarity for my sake. Thanks. -- -James
Am 22.08.2016 um 16:35 schrieb lingpanda101--- via samba:> This patch shows two attachments.Are you talking about a patch file or a bug report? A patch is one or more text files containing the before/after diff. It doesn't have any attachments. Can you send me the patch file / bugzilla link? This makes it easier to see if we are talking about the same thing.> One for 4.3 and one for 4.4 cherry > picked from master. I take this as anytime someone updates 4.3 to a new > revision, they must apply this patch unless it's stated in a release note.If something was fixed in the master branch, the changes (commit) can be cherry-picked to a release branch, like 4.4. This means that this update is now part of the 4.4 code repository and the next time a 4.4 release is created, it will be included. Regards, Marc
On 8/22/2016 1:52 PM, Marc Muehlfeld wrote:> Are you talking about a patch file or a bug report? A patch is one or > more text files containing the before/after diff. It doesn't have any > attachments. > > Can you send me the patch file / bugzilla link? This makes it easier to > see if we are talking about the same thing.https://bugzilla.samba.org/show_bug.cgi?id=11520> > If something was fixed in the master branch, the changes (commit) can be > cherry-picked to a release branch, like 4.4. This means that this update > is now part of the 4.4 code repository and the next time a 4.4 release > is created, it will be included. > > > > > Regards, > MarcThank you for the explanation. This answer my question. -- -James