samba - Oct 2010 - The filename of list of smbclient contains spaces

Hi,

Please forgive me to disturb you all. We have attempted
to make a patch to resolve the following problems.
https://bugzilla.samba.org/show_bug.cgi?id=7700
https://bugzilla.samba.org/show_bug.cgi?id=7701

Please let me introduce one in detail. For the 1st problem
that we found when we do the following command,
$ smbclient //13.187.241.5/test -U test%123456 -c "mkdir xxx"
the return value is always "0" regardless of the command
is correct or incorrect. The commands, "rd" and "rm" have
the same problem.
We can obtain the returned value by calling this shell,
$ echo $?
after calling of smbclient.

For the 2nd one, please to refer to the descriptions within the
URL https://bugzilla.samba.org/show_bug.cgi?id=7701

Finally, we cloned the source from git://git.samba.org/samba.git,
made a patch and attached it, for both bugs. We built the
executable file under "source3" successfully, and confirmed
some features briefly, in our local PC.

Would you like to review and commit, if it can be done, the
patch for us please?

Any help and suggestion will be appreciated.
Thanks.

Best
Brandon. Wang
2010/10/28

On Thu, Oct 28, 2010 at 02:56:26PM +0800, Wang, Brandon
wrote:
> Please forgive me to disturb you all. We have attempted
> to make a patch to resolve the following problems.
> https://bugzilla.samba.org/show_bug.cgi?id=7700
> https://bugzilla.samba.org/show_bug.cgi?id=7701
> 
> Please let me introduce one in detail. For the 1st problem
> that we found when we do the following command,
> $ smbclient //13.187.241.5/test -U test%123456 -c "mkdir xxx"
> the return value is always "0" regardless of the command
> is correct or incorrect. The commands, "rd" and "rm"
have
> the same problem.
> We can obtain the returned value by calling this shell,
> $ echo $?
> after calling of smbclient.
> 
> For the 2nd one, please to refer to the descriptions within the
> URL https://bugzilla.samba.org/show_bug.cgi?id=7701
> 
> Finally, we cloned the source from git://git.samba.org/samba.git,
> made a patch and attached it, for both bugs. We built the
> executable file under "source3" successfully, and confirmed
> some features briefly, in our local PC.
> 
> Would you like to review and commit, if it can be done, the
> patch for us please?
Sure! The problem is that the samba-mailing list drops
attachments. You could either upload the patches to some
public git hoster like repo.or.cz or so, or attach them to
the bugzilla entries. The latter would probably be simplest
for you.

Thanks,

Volker

Thank you for your great suggestion.
I have attached it to the bugzilla entries. 
Could you get it from the following URL, please?
https://bugzilla.samba.org/attachment.cgi?id=6038&action=edit
or https://bugzilla.samba.org/show_bug.cgi?id=7701

Thank you very much!

Brandon
> -----Original Message-----
> From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE]
> Sent: 2010?10?28? 15:23
> To: Wang, Brandon
> Cc: samba at lists.samba.org
> Subject: Re: [Samba] The filename of list of smbclient contains spaces
> 
> On Thu, Oct 28, 2010 at 02:56:26PM +0800, Wang, Brandon wrote:
> > Please forgive me to disturb you all. We have attempted
> > to make a patch to resolve the following problems.
> > https://bugzilla.samba.org/show_bug.cgi?idw00
> > https://bugzilla.samba.org/show_bug.cgi?idw01
> >
> > Please let me introduce one in detail. For the 1st problem
> > that we found when we do the following command,
> > $ smbclient //13.187.241.5/test -U test%123456 -c "mkdir
xxx"
> > the return value is always "0" regardless of the command
> > is correct or incorrect. The commands, "rd" and
"rm" have
> > the same problem.
> > We can obtain the returned value by calling this shell,
> > $ echo $?
> > after calling of smbclient.
> >
> > For the 2nd one, please to refer to the descriptions within the
> > URL https://bugzilla.samba.org/show_bug.cgi?idw01
> >
> > Finally, we cloned the source from git://git.samba.org/samba.git,
> > made a patch and attached it, for both bugs. We built the
> > executable file under "source3" successfully, and confirmed
> > some features briefly, in our local PC.
> >
> > Would you like to review and commit, if it can be done, the
> > patch for us please?
> 
> Sure! The problem is that the samba-mailing list drops
> attachments. You could either upload the patches to some
> public git hoster like repo.or.cz or so, or attach them to
> the bugzilla entries. The latter would probably be simplest
> for you.
> 
> Thanks,
> 
> Volker