Marc Aurèle La France
2023-May-17 02:15 UTC
[PATCH] Fix the counting of device files and symlinks
Device files should be counted as devices, not symlinks. Marc. diff -aNpRruz -X /etc/diff.excludes rsync-3.2.7/delete.c devel-3.2.7/delete.c --- rsync-3.2.7/delete.c 2020-06-13 20:15:02.000000000 -0600 +++ devel-3.2.7/delete.c 2020-06-13 20:15:02.000000000 -0600 @@ -188,7 +188,7 @@ enum delret delete_item(char *fbuf, uint16 mode, uint16 flags) stats.deleted_symlinks++; #endif else if (IS_DEVICE(mode)) - stats.deleted_symlinks++; + stats.deleted_devices++; else stats.deleted_specials++; } diff -aNpRruz -X /etc/diff.excludes rsync-3.2.7/flist.c devel-3.2.7/flist.c --- rsync-3.2.7/flist.c 2022-10-02 10:54:54.000000000 -0600 +++ devel-3.2.7/flist.c 2022-10-02 10:54:54.000000000 -0600 @@ -2659,7 +2659,7 @@ struct file_list *recv_file_list(int f, int dir_ndx) } else if (S_ISLNK(file->mode)) stats.num_symlinks++; else if (IS_DEVICE(file->mode)) - stats.num_symlinks++; + stats.num_devices++; else stats.num_specials++;
On Tue, May 16, 2023 at 7:28?PM Marc Aur?le La France via rsync < rsync at lists.samba.org> wrote:> Device files should be counted as devices, not symlinks. >Thanks for the catch! I fixed this the other day. ..wayne.. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.samba.org/pipermail/rsync/attachments/20230526/0310928c/attachment.htm>
Apparently Analagous Threads
- [PATCH] Add --omit-{device,special}-times options
- [Bug 12806] Deleting in a row of hardlinked snapshots resets file permissions.
- DO NOT REPLY [Bug 7565] New: --check-point=<TIME> +options.c.patch +generator.c.patch
- [PATCH] Fix documentation typo
- [Bug 12806] New: Deleting in a row of hardlinked snapshots resets file permissions.