rsync - May 2020 - [PATCH] Optimized assembler version of md5_process() for x86-64

On 2020-05-22 22:54:18 [-0700], Wayne Davison via rsync
wrote:
> Thanks for the optimizing patches, Jorrit!  I've merged your latest
changes
> into the git master branch.
Wouldn't it be better to add support for a crypto library (like openssl)
which would provide optimized algorithms for more than just one platform
without the need to maintain it separately?
> ..wayne..
Sebastian

On Sat, May 23, 2020 at 4:37 AM Sebastian Andrzej Siewior <
rsync at ml.breakpoint.cc> wrote:
> Wouldn't it be better to add support for a crypto library (like
openssl)
> which would provide optimized algorithms for more than just one platform
> without the need to maintain it separately?
>
Adding optional support for openssl's crypto library is also a good idea.
I've made rsync's MD5 code able to support using either the crypto
library
or the rsync-included MD5 code.  I did not bother to try to support it for
MD4 checksums, since those are mostly historical & there are some weird
exceptions for really old rsync compatibility that would need to be worked
out.  However, I might make it where the main MD4 checksum is covered by
openssl and just the historical ones get the historical code.

I've also added a comment to the checksum.c file about my support of being
able to distribute a dynamically linked version of rsync that links with
the openssl and xxhash libraries (since they are both BSD 2-clause
licensed), especially since this should (IMO) be considered to be covered
under the System Libraries part of the GPL.

..wayne..
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.samba.org/pipermail/rsync/attachments/20200523/1a071b78/attachment.htm>

On 2020-05-23 10:21:31 [-0700], Wayne Davison wrote:
> 
> Adding optional support for openssl's crypto library is also a good
idea.
I posted [0] openssl support with SHA1 support and asked whether openssl is
possible. At that time added md5 and I think md4. I received no feedback
bach then but if you want me to respin the openssl part (without sha1
now that we have xxhash) I can certainly do that.
> I've also added a comment to the checksum.c file about my support of
being
> able to distribute a dynamically linked version of rsync that links with
> the openssl and xxhash libraries (since they are both BSD 2-clause
> licensed), especially since this should (IMO) be considered to be covered
> under the System Libraries part of the GPL.
also, openssl 3.0 will be apache-2 licensed.

[0] https://lists.samba.org/archive/rsync/2020-February/032062.html
> ..wayne..
Sebastian

On Sat, 23 May 2020 10:21:31 -0700
Wayne Davison via rsync <rsync at lists.samba.org> wrote:
> Adding optional support for openssl's crypto library is also a good
> idea.
There is also libressl to consider, if you're considering libraries.

Karl <kop at meme.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Thank you, Sebastian.
> On 23 May 2020, at 13:37, Sebastian Andrzej Siewior via rsync <rsync at
lists.samba.org> wrote:
> 
> On 2020-05-22 22:54:18 [-0700], Wayne Davison via rsync wrote:
>> Thanks for the optimizing patches, Jorrit!  I've merged your latest
changes
>> into the git master branch.
> 
> Wouldn't it be better to add support for a crypto library (like
openssl)
> which would provide optimized algorithms for more than just one platform
> without the need to maintain it separately?
> 
>> ..wayne..
> 
> Sebastian
> 
> -- 
> Please use reply-all for most replies to avoid omitting the mailing list.
> To unsubscribe or change options:
https://lists.samba.org/mailman/listinfo/rsync
> Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html