samba-bugs at samba.org
2018-Nov-27 08:49 UTC
[Bug 13692] New: Coverity scan for rsync-3.1.3
https://bugzilla.samba.org/show_bug.cgi?id=13692 Bug ID: 13692 Summary: Coverity scan for rsync-3.1.3 Product: rsync Version: 3.1.3 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core Assignee: wayned at samba.org Reporter: mruprich at redhat.com QA Contact: rsync-qa at samba.org Created attachment 14689 --> https://bugzilla.samba.org/attachment.cgi?id=14689&action=edit Covscan report with commentary Hi, I ran a coverity scan(static analyser) on rsync-3.1.3 and it found some 100 issues. I am enclosing the complete report as an attachment. On the bottom of the file, there is my commentary for each defect found by the scanner. The scanner is far from perfect so there might be a lot of false positives(I have marked those in the commentary). Also, there are things I could not figure out whether they are false positives or not. I would like to ask someone with a deeper knowledge of the code to either confirm or disprove my findings. After that I will be more than happy to send a patch that will fix some of these issues. Thanks and regards, Michal -- You are receiving this mail because: You are the QA Contact for the bug.
https://bugzilla.samba.org/show_bug.cgi?id=13692 Wayne Davison <wayne at opencoder.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Wayne Davison <wayne at opencoder.net> --- Thanks for the report. I fixed a bunch of the issues, but left alone some of the items that only affect start-up (one-time) string allocations. If you see any important ones that I missed, feel free to let me know. Also feel free to add a follow-up coverity scan to this bug and I'll give it a check to see what I missed. -- You are receiving this mail because: You are the QA Contact for the bug.
Apparently Analagous Threads
- [Bug 14365] New: 3.1.3 cygwin compilation failure
- [Bug 11101] New: support writing to devices
- [Bug 11166] New: running with -vvv causes a hang
- DO NOT REPLY [Bug 7249] New: Add an option to use O_NOATIME
- [Bug 14390] New: Feature request: don't fail if using "-z" transferring to rsync complied with --with-included-zlib=no