rsync - Sep 2016 - [Bug 12199] New: multiple link-dest dirs not working

https://bugzilla.samba.org/show_bug.cgi?id=12199

            Bug ID: 12199
           Summary: multiple link-dest dirs not working
           Product: rsync
           Version: 3.0.6
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: brian at interlinx.bc.ca
        QA Contact: rsync-qa at samba.org

If I try to use multiple --link-dest dirs they are not being searched
exhaustively for a file to link to.  Observe:

# rsync -aiSPHAX --link-dest $PWD/monthly.0/f/sbin/ --link-dest
$PWD/monthly.1.new/f/sbin/ --link-dest $PWD/weekly.3/f/sbin/ weekly.3/f/sbin/
weekly.3.new/f/sbin/
.d..t...... ./
cf........x consoletype
# ls -li */f/sbin/consoletype
705305954 -rwxr-xr-x. 3 root root 7896 Nov  4  2014
monthly.0/f/sbin/consoletype
705305954 -rwxr-xr-x. 3 root root 7896 Nov  4  2014
monthly.1/f/sbin/consoletype
705305954 -rwxr-xr-x. 3 root root 7896 Nov  4  2014
monthly.1.new/f/sbin/consoletype
171574019 -rwxr-xr-x. 1 root root 7896 Nov  4  2014 weekly.3/f/sbin/consoletype
403439863 -rwxr-xr-x. 1 root root 7896 Nov  4  2014
weekly.3.new/f/sbin/consoletype
# ls -lZ */f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:consoletype_exec_t:s0
monthly.0/f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:consoletype_exec_t:s0
monthly.1/f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:consoletype_exec_t:s0
monthly.1.new/f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:unlabeled_t:s0
weekly.3/f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:unlabeled_t:s0
weekly.3.new/f/sbin/consoletype
# rm -f weekly.3.new/f/sbin/consoletype
# rsync -aiSPHAX --link-dest $PWD/weekly.3/f/sbin/ weekly.3/f/sbin/
weekly.3.new/f/sbin/
# ls -li */f/sbin/consoletype
705305954 -rwxr-xr-x. 3 root root 7896 Nov  4  2014
monthly.0/f/sbin/consoletype
705305954 -rwxr-xr-x. 3 root root 7896 Nov  4  2014
monthly.1/f/sbin/consoletype
705305954 -rwxr-xr-x. 3 root root 7896 Nov  4  2014
monthly.1.new/f/sbin/consoletype
171574019 -rwxr-xr-x. 2 root root 7896 Nov  4  2014 weekly.3/f/sbin/consoletype
171574019 -rwxr-xr-x. 2 root root 7896 Nov  4  2014
weekly.3.new/f/sbin/consoletype
# ls -lZ */f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:consoletype_exec_t:s0
monthly.0/f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:consoletype_exec_t:s0
monthly.1/f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:consoletype_exec_t:s0
monthly.1.new/f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:unlabeled_t:s0
weekly.3/f/sbin/consoletype
-rwxr-xr-x. root root system_u:object_r:unlabeled_t:s0
weekly.3.new/f/sbin/consoletype

So as you can see, in both cases, the target file was created and had the
correct (selinux) xattrs but in the first case it was created as a separate
file and in the second case it was created as a link, as I would have expected
in both cases.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=12199

--- Comment #1 from Kevin Korb <rsync at sanitarium.net> ---
I have been discussing this in IRC for more than an hour now.  The OP's
complaint is not that multiple --link-dest paths aren't searched.  The
OP's
complaint is that rsync finds an apparent match in an early --link-dest path
and it does not notice a more precise (metadata) match in a subsequent
--link-dest path.  The result is rsync making a new file to record a change in
xattr even though both file+xattr already exist in the declared link-dests.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=12199

--- Comment #2 from Brian J. Murrell <brian at interlinx.bc.ca> ---
No triage on this at least?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.