rsync - Dec 2014 - [Bug 10995] New: rsync -aFF crashes when parent directory of source directory has a .rsync-filter file with a dir-merge rule in it

https://bugzilla.samba.org/show_bug.cgi?id=10995

            Bug ID: 10995
           Summary: rsync -aFF crashes when parent directory of source
                    directory has a .rsync-filter file with a dir-merge
                    rule in it
           Product: rsync
           Version: 3.1.0
          Hardware: x64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: lars.tiede at gmail.com
        QA Contact: rsync-qa at samba.org

Run the following in an empty directory to reproduce:

mkdir src-parent
echo "dir-merge,- .gitignore" > src-parent/.rsync-filter
mkdir src-parent/src
mkdir src-parent/src/subdir
mkdir dest

rsync -aFF src-parent/src/ dest/


On Ubuntu 14.04 with the rsync version that ships with Ubuntu (rsync  version
3.1.0  protocol version 31), I get the following output:

rsync: exclude.c:584: pop_local_filters: Assertion `mergelist_cnt
=old_mergelist_cnt' failed.
Aborted (core dumped)


On OS X 10.10 with rsync version 2.6.9  protocol version 29, this runs without
problems.


It looks like rsync looks too far up the directory tree for filter rules, and
then gets confused.

Note that the above steps are minimal as far as I was able to isolate the bug:
remove the filter rule and it works. Remove the -a flag and it works. Remove
src-parent/src/subdir and it doesn't crash (the empty subdir is not copied
over, though).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10995

--- Comment #1 from Lars Tiede <lars.tiede at gmail.com> ---
Sorry, my last paragraph came out confusing. It should read:

Note that the above steps are minimal with respect to as far as I was able to
isolate the bug: remove the filter rule and it works. Remove
src-parent/src/subdir and it works. Remove the -a flag and it doesn't crash
(the empty subdir is not copied over, though).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10995

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Wayne Davison <wayned at samba.org> ---
I just made some changes to the dir-merge code that fixed up the issue you were
seeing.  It will be in the next release.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.