rsync - May 2008 - DO NOT REPLY [Bug 5459] New: Large amount of files makes checksum count negative

https://bugzilla.samba.org/show_bug.cgi?id=5459

           Summary: Large amount of files makes checksum count negative
           Product: rsync
           Version: 3.0.2
          Platform: x64
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: count-linux@flatline.de
         QAContact: rsync-qa@samba.org


read_sum_head() in io.c expects the checksum count to be a signed int (most
likely should be long). For large file counts, this can become negative:

receiving file list ...
2289961 files to consider
Invalid checksum count -909869055 [sender]
rsync error: protocol incompatibility (code 2) at io.c(1361) [sender=3.0.2]
rsync: connection unexpectedly closed (31026252 bytes received so far)
[receiver]
rsync error: error in rsync protocol data stream (code 12) at io.c(635)
[receiver=3.0.2]
rsync: connection unexpectedly closed (31026252 bytes received so far)
[generator]
rsync error: error in rsync protocol data stream (code 12) at io.c(635)
[generator=3.0.2]

... and this is only a subfolder. Working with the original 55137908 in one
block doesn't work at all.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5459


count-linux@flatline.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |minor
            Summary|Large amount of files makes |Defective FS structure can
                   |checksum count negative     |make checksum count negative




------- Comment #1 from count-linux@flatline.de  2008-05-12 13:41 CST -------
seems like a broken directory entry causes this:

-rwxr-x-w- 1 1727  521 1006641549938245 2007-12-10 15:04 709.jpg

.. so this is an FS problem, not an rsync problem. rsync should provide a
better error description, though.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5459


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #2 from wayned@samba.org  2008-05-12 18:27 CST -------
I agree that the generator should not request a file that it cannot send the
right count of checksums for.  (Which should be something in the range of a 256
TB file or so.)


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5459


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #3 from wayned@samba.org  2008-05-31 12:18 CST -------
The code now checks to ensure that the checksum structure is valid before
sending it over the wire.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.