rsync - Sep 2006 - DO NOT REPLY [Bug 4138] New: Incoming chmod can't override inherited directory setgid

https://bugzilla.samba.org/show_bug.cgi?id=4138

           Summary: Incoming chmod can't override inherited directory setgid
           Product: rsync
           Version: 2.6.9
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: hashproduct+rsync@gmail.com
         QAContact: rsync-qa@samba.org


[I mentioned this on the mailing list but nothing happened.  I'm entering it
in
Bugzilla so it won't be forgotten.]

When --perms is off, an incoming chmod of "Dg-s" does not prevent new
directories on the receiver from inheriting setgid bits; it probably should. 
Incoming chmod currently takes effect in dest_mode, which is too soon for it to
affect the directory setgid check in set_file_attrs.

To avoid further bugs of this nature, I propose that incoming chmod
should take effect right before the actual call to chmod in
set_file_attrs, as rsyncd-perm once did.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4138


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #1 from wayned@samba.org  2006-10-08 17:03 MST -------
I checked-in a fix that moves where the "incoming chmod" rules tweak
the file's
mode (so that it happens at the last moment prior to setting the file's
permissions).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.