rsync - Sep 2006 - --remove-sent-files errors with no output

I've been experimenting with the --remove-sent-files option with patchy
success.
Often --remove-sent-files will not remove the remote files.  It copies
them locally but "apparently" failed to remove them remotely.  After
some experimentation I was able to identify one problem as a permission
problem.  I continue to have problems with rsync not removing some more
files.  What troubles me even is, using rsync -vvv, rsync shows no
output relating to the --remove-sent-files option.  No error messages,
no executing delete statements, etc.   Any suggestions on getting rsync
to produce more verbose output.  I'd love to see it say deleting file X
-- Error: Y

Thanks

Eric C. Aiken
Senior Systems Administrator

CarDomain Network
1633 Westlake Ave, North
Suite 100
Seattle, WA 98109
 
Phone: 206.926.2149
Fax: 206.926.2299

On Tue, Sep 19, 2006 at 03:47:38PM -0700, Eric Aiken
wrote:
> What troubles me even is, using rsync -vvv, rsync shows no output
> relating to the --remove-sent-files option.
You would have seen the messages with just -vv if it were successful at
removing the files.  For some strange reason, it wasn't outputting any
errors if it failed to remove the files, though.  The following patch
changes this.

..wayne..
-------------- next part --------------
--- sender.c	30 Jun 2006 15:52:52 -0000	1.99
+++ sender.c	20 Sep 2006 01:50:01 -0000
@@ -134,8 +134,13 @@ void successful_send(int ndx)
 	} else
 		offset = 0;
 	f_name(file, fname + offset);
-	if (remove_source_files && do_unlink(fname) == 0 && verbose
> 1)
-		rprintf(FINFO, "sender removed %s\n", fname + offset);
+	if (remove_source_files) {
+		if (do_unlink(fname) == 0) {
+			if (verbose > 1)
+				rprintf(FINFO, "sender removed %s\n", fname + offset);
+		} else
+			rsyserr(FERROR, errno, "sender failed to remove %s", fname +
offset);
+	}
 }
 
 static void write_ndx_and_attrs(int f_out, int ndx, int iflags,