rsync - May 2006 - DO NOT REPLY [Bug 3806] New: makedev has 3 arguments in qnx

https://bugzilla.samba.org/show_bug.cgi?id=3806

           Summary: makedev has 3 arguments in qnx
           Product: rsync
           Version: 2.6.8
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: cooke@sun.ac.za
         QAContact: rsync-qa@samba.org


Hello,

I cross-compiled rsync to QNX on a sh4 embedded system. When compiling the file
flist.c I get the error that makedev requires 3 arguments but only 2 are
supplied.

I went and looked at how it is defined in QNX and according to the QNX website
(http://www.qnx.com/developers/docs/6.3.0SP1/neutrino/lib_ref/s/stat.html) the
makedev works as follows in QNX:

makedev( node, major, minor)
    Build a device ID from the given numbers. Currently, the node argument
isn't used and must be zero

So what I did to fix the problem is defined:
#define MAKEDEV(a,b) makedev(0,a,b)

and then replaced makedev with MAKEDEV in the file flist.c The code compiled
and appears to be working properly.

So it would be good to add a test to the configure script that tests for the 3
argument form of makedev and sets the define shown above accordingly and also
handles the mkdev define mentioned in bug report 2357
(https://bugzilla.samba.org/show_bug.cgi?id=2357) that is currently handled.

Anyway hope this helps someone.

Adrian


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3806


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #1 from wayned@samba.org  2006-07-09 23:27 MST -------
The version in CVS now has a configure script that checks if makedev() takes 3
args, and the software now uses this information to define the right MAKEDEV()
macro.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.