> On Mon, Mar 20, 2006 at 04:51:56PM -0500, Jonathan Call wrote: > > It refers to a --flags patch that I don't see available anywhere: > I used the link to the patch in the email you cited to find it. It's > quite old though, and I saw one bug (namely that the SAME_FLAG value was > too big to actually be transmitted as a flag bit). I did a quick update > of the patch so that it applies to the CVS version:Is it possible to have this patch committed to the official release? If more testing or tweaking is required, I would be happy to provide access to a freebsd machine for this purpose.
On Sat, 2006-04-01 at 19:22 -0500, Surer Dink wrote:> Is it possible to have this patch committed to the official release?I daresay ACLs are at least as commonly used as BSD flags, so if official rsync adopts flags, could it adopt ACLs (or at least default ACL observance, without which rsync's behavior is inconsistent with that of every other utility)? First, it would be prudent to check that an rsync patched but not configured for ACLs is built from the same preprocessed code as one not patched for ACLs. -- Matt McCutchen hashproduct@verizon.net http://hashproduct.metaesthetics.net/
On Sat, Apr 01, 2006 at 07:22:59PM -0500, Surer Dink wrote:> Is it possible to have this patch committed to the official release?The patch as it currently exists is not yet good enough for the trunk (e.g. it makes the code less efficient by introducing a superfluous stat() call). I will be considering including it at a later time after it has been improved. ..wayne..
That would be very much appreciated. Thank You.> -----Original Message----- > From: rsync-bounces+jcall=verio.net@lists.samba.org [mailto:rsync- > bounces+jcall=verio.net@lists.samba.org] On Behalf Of Wayne Davison > Sent: Saturday, April 01, 2006 10:50 PM > To: Surer Dink > Cc: rsync@lists.samba.org > Subject: Re: rsync and BSD file flags > > On Sat, Apr 01, 2006 at 07:22:59PM -0500, Surer Dink wrote: > > Is it possible to have this patch committed to the official release? > > The patch as it currently exists is not yet good enough for the trunk > (e.g. it makes the code less efficient by introducing a superfluous > stat() call). I will be considering including it at a later timeafter> it has been improved. > > ..wayne.. > -- > To unsubscribe or change options: > https://lists.samba.org/mailman/listinfo/rsync > Before posting, read:http://www.catb.org/~esr/faqs/smart-questions.html