rsync - Oct 2005 - [Bug 3174] Patch for specifying zlib compression level

https://bugzilla.samba.org/show_bug.cgi?id=3174





------- Additional Comments From stix@stix.homeunix.net  2005-10-17 04:14
-------
Created an attachment (id=1517)
 --> (https://bugzilla.samba.org/attachment.cgi?id=1517&action=view)
rsync compression level patch


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3174


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1517 is|0                           |1
           obsolete|                            |




------- Additional Comments From wayned@samba.org  2005-10-17 13:59 -------
Created an attachment (id=1520)
 --> (https://bugzilla.samba.org/attachment.cgi?id=1520&action=view)
My version of adding optional compression-level selection

Here's a patch that should accomplish the same thing, while avoiding the
problems I mentioned above.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3174


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From wayned@samba.org  2005-10-17 13:49 -------
The problem with using an optional arg with popt is that a following option
(e.g. "--compress -v") treats the following option as the arg to
--compress
(which seems to be what your popt patch fixes).  Since we want to support using
a shared popt library, that means that optional args can't be used.

Also, your changes to batch.c created an incompatible batch-file format.  To
remain compatible, you need to make sure that the existing 0 and 1 values in
batch files continue to mean what 0 and -1 mean in your patch.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3174


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2005-10-26 09:46 -------
The --compress-level option was committed to CVS.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3174





------- Additional Comments From stix@stix.homeunix.net  2005-11-05 23:58
-------
I've tested the changes, which were actually very similar to my first pass
at a
patch which we've been using for almost a year on production systems
(rsyncing
live Oracle databases between continents). I decided against the
--compress-level option as it breaks if rsync is too old on the other end, and I
was trying to allow older versions to skip the option transparently.

Regardless, so long as the ability to change the compression ability is allowed,
I don't mind how it is implemented. Thanks!

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.